Pepper: specify the security origin when enumerating media devices.

content/public/renderer/renderer_ppapi_host.h

Index: content/public/renderer/renderer_ppapi_host.h
diff --git a/content/public/renderer/renderer_ppapi_host.h b/content/public/renderer/renderer_ppapi_host.h
index 88a863fd2d72d6313fdc517d34a223cd0291caf2..9c5998c29e180cff1028bffc92976f1d6c541887 100644
--- a/content/public/renderer/renderer_ppapi_host.h
+++ b/content/public/renderer/renderer_ppapi_host.h
@@ -14,6 +14,7 @@
 #include "content/common/content_export.h"
 #include "ipc/ipc_platform_file.h"
 #include "ppapi/c/pp_instance.h"
+#include "url/gurl.h"
 
 namespace base {
 class FilePath;
@@ -128,6 +129,10 @@ class RendererPpapiHost {
       const std::vector<IPC::Message>& nested_msgs,
       const base::Callback<void(const std::vector<int>&)>& callback) const = 0;
 
+  // Gets the URL of the document containing the given PP_Instance.
+  // Returns an empty URL if the instance is invalid.
+  virtual GURL GetDocumentURL(PP_Instance instance) const = 0;

[bbudge, 2013/10/31 00:31:42]

Can't you detect if the instance is valid using GetPluginInstance and access the
document URL through the plugin container? In other words, couldn't you
implement this here rather than making it pure virtual?

[yzshen1, 2013/10/31 00:52:03]

I think this is a pure interface, we don't provide implementation for any of
these methods here. What do you think? Thanks!

[bbudge, 2013/10/31 01:10:02]

It looks like a "convenience method" so I think it's better to implement it
somewhere in terms of this interface. It could be a static method declared and
defined here or somewhere else. Otherwise, every implementor of this interface
has to code it.

I think the Google C++ style guide allows static methods on pure interfaces:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Interfaces

But we should double check with a content/ OWNER.

[yzshen1, 2013/11/01 17:00:00]

There are a few other methods in this interface are the same as
GetDocumentURL():
GetRenderViewForInstance
GetContainerForInstance

I would like them to be consistent. (Either do GetDocumentURL in the current way
or change all of them.)

I think using static methods has one issue: we will have to pass in a
RendererPpapiHost pointer as "this".

What do you think? Thanks!


On 2013/10/31 01:10:02, bbudge1 wrote:

+
  protected:
   virtual ~RendererPpapiHost() {}
 };