Pepper: specify the security origin when enumerating media devices.

content/public/renderer/renderer_ppapi_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_
 #define CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_
 
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/platform_file.h"
 #include "base/process/process.h"
 #include "content/common/content_export.h"
 #include "ipc/ipc_platform_file.h"
 #include "ppapi/c/pp_instance.h"
+#include "url/gurl.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace gfx {
 class Point;
 }
 
 namespace IPC {
@@ skipping 94 matching lines @@
   // resource host creation messages and |instance| is the PP_Instance which
   // the resource will belong to. |callback| will be called asynchronously with
   // the pending host IDs when the ResourceHosts have been created. This can be
   // passed back to the plugin to attach to the ResourceHosts. Pending IDs of 0
   // will be passed to the callback if a ResourceHost fails to be created.
   virtual void CreateBrowserResourceHosts(
       PP_Instance instance,
       const std::vector<IPC::Message>& nested_msgs,
       const base::Callback<void(const std::vector<int>&)>& callback) const = 0;
 
+  // Gets the URL of the document containing the given PP_Instance.
+  // Returns an empty URL if the instance is invalid.
+  virtual GURL GetDocumentURL(PP_Instance instance) const = 0;

[bbudge, 2013/10/31 00:31:42]

Can't you detect if the instance is valid using GetPluginInstance and access the
document URL through the plugin container? In other words, couldn't you
implement this here rather than making it pure virtual?

[yzshen1, 2013/10/31 00:52:03]

I think this is a pure interface, we don't provide implementation for any of
these methods here. What do you think? Thanks!

[bbudge, 2013/10/31 01:10:02]

It looks like a "convenience method" so I think it's better to implement it
somewhere in terms of this interface. It could be a static method declared and
defined here or somewhere else. Otherwise, every implementor of this interface
has to code it.

I think the Google C++ style guide allows static methods on pure interfaces:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Interfaces

But we should double check with a content/ OWNER.

[yzshen1, 2013/11/01 17:00:00]

There are a few other methods in this interface are the same as
GetDocumentURL():
GetRenderViewForInstance
GetContainerForInstance

I would like them to be consistent. (Either do GetDocumentURL in the current way
or change all of them.)

I think using static methods has one issue: we will have to pass in a
RendererPpapiHost pointer as "this".

What do you think? Thanks!


On 2013/10/31 01:10:02, bbudge1 wrote:

+
  protected:
   virtual ~RendererPpapiHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDERER_PPAPI_HOST_H_