Issue 487233004: Audio Directive Handler cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 487233004: Audio Directive Handler cleanup (Closed)

Created:
6 years, 4 months ago by Charlie

Modified:
6 years, 3 months ago

Reviewers:
rkc

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Audio Directive Handler cleanup Committed: https://crrev.com/4e90455de5dbcc2ff8479166c317ba0c9a826127 Cr-Commit-Position: refs/heads/master@{#291786}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -21 lines)			Patch
	M	components/copresence/handlers/audio/audio_directive_handler.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
	M	components/copresence/handlers/audio/audio_directive_handler.cc	View		3 chunks	+14 lines, -17 lines	0 comments	Download

Total messages: 7 (0 generated)

Charlie

I think this makes the code more readable. Let me know what you think.

6 years, 4 months ago (2014-08-19 20:15:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/487233004/20001

6 years, 3 months ago (2014-08-25 21:31:15 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...

6 years, 3 months ago (2014-08-25 22:38:44 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (20001) as b4ccc6b3a066f1272b57c7766e1ab3dfc5ae928e

6 years, 3 months ago (2014-08-25 23:37:52 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:38:30 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/4e90455de5dbcc2ff8479166c317ba0c9a826127
Cr-Commit-Position: refs/heads/master@{#291786}