Source/core/rendering/compositing/CompositingReasonFinder.cpp - Issue 486493002: Merge AcceleratedCompositingForOverflowScroll into PreferCompositingToLCDText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 486493002: Merge AcceleratedCompositingForOverflowScroll into PreferCompositingToLCDText. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rm-overflowscroll: imagefailure Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/compositing/CompositedLayerMapping.cpp ('k') | Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp

diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp

index 02ad6c6ccc14addd40c12f3fa028f3590f446e9d..c4014060e6a5eb3b27ef8de8c1fbc32ea22f6c99 100644

--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp

+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp

@@ -29,13 +29,9 @@ void CompositingReasonFinder::updateTriggers()

Settings& settings = m_renderView.document().page()->settings();

if (settings.preferCompositingToLCDTextEnabled()) {

m_compositingTriggers |= ScrollableInnerFrameTrigger;

+ m_compositingTriggers |= OverflowScrollTrigger;

m_compositingTriggers |= ViewportConstrainedPositionedTrigger;

}

- // We map both these settings to universal overlow scrolling.

- // FIXME: Replace these settings with a generic compositing setting for HighDPI.

- if (settings.acceleratedCompositingForOverflowScrollEnabled() || settings.compositorDrivenAcceleratedScrollingEnabled())

- m_compositingTriggers |= OverflowScrollTrigger;

}

bool CompositingReasonFinder::hasOverflowScrollTrigger() const