Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 486333002: Revert of Adjust autofilled property for <search> input and <select> elements. (Closed)

Created:
6 years, 4 months ago by dglazkov
Modified:
6 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Adjust autofilled property for <search> input and <select> elements. (patchset #4 of https://codereview.chromium.org/471803003/) Reason for revert: Broke AutofillDialogControllerTest: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java&l=324 Original issue's description: > Adjust autofilled property for <search> input and <select> elements. > > Set value of autofilled property to false in the following cases: > - Cancel search via cancel button in <search> element. > - Delete autofilled selected <select> option. > > This patch also > - Merged test case for editing text in autofilled textarea. > > R=isherman@chromium.org, tkent@chromium.org > BUG=395627 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180550 TBR=isherman@chromium.org,tkent@chromium.org,ziran.sun@samsung.com NOTREECHECKS=true NOTRY=true BUG=395627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -154 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/input-autofilled.html View 1 chunk +108 lines, -115 lines 0 comments Download
M LayoutTests/fast/forms/input-autofilled-expected.txt View 1 chunk +2 lines, -33 lines 0 comments Download
A LayoutTests/fast/forms/textarea/edit-autofilled-text.html View 1 chunk +67 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/textarea/edit-autofilled-text-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dglazkov
Created Revert of Adjust autofilled property for <search> input and <select> elements.
6 years, 4 months ago (2014-08-19 16:43:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/486333002/1
6 years, 4 months ago (2014-08-19 16:43:46 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 16:44:03 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 16:44:04 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 195.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
f7dcf0650ae5665ba6d8e9e711d5abbdb7b6ac01..f08e71d8b9b4bd9a5a90bc4c42d634bdb2519c57
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -195,9 +195,6 @@
 crbug.com/394698 fast/repaint/japanese-rl-selection-clear.html [
NeedsRebaseline ]
 crbug.com/394698 compositing/squashing/selection-repaint-with-gaps.html [
NeedsRebaseline ]
 crbug.com/394698
editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root.html
[ NeedsRebaseline ]
-
-# Falied test in Win
-crbug.com/395627 [ Win ] fast/forms/input-autofilled.html [ NeedsRebaseline ]
 
 crbug.com/380217
virtual/regionbasedmulticol/fast/multicol/newmulticol/layers-in-multicol.html [
Skip ]
 crbug.com/380217 [ Linux Win ]
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html
[ Skip ]

Powered by Google App Engine
This is Rietveld 408576698