Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 486233002: Re-enabled a couple of ExtensionCrxInstallerTests: (Closed)

Created:
6 years, 4 months ago by Joao da Silva
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Re-enabled a couple of ExtensionCrxInstallerTests: - Whitelisting is disabled on ChromeOS by design; - PackAndInstallExtension passes on a local ChromeOS build; - AllowOffStore needed a fix in its waiting logic and now passes too. BUG=404789, 136397, 140893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290805

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : rename test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 5 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 4 months ago (2014-08-19 14:05:39 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/486233002/diff/20001/chrome/browser/extensions/crx_installer_browsertest.cc File chrome/browser/extensions/crx_installer_browsertest.cc (right): https://codereview.chromium.org/486233002/diff/20001/chrome/browser/extensions/crx_installer_browsertest.cc#newcode237 chrome/browser/extensions/crx_installer_browsertest.cc:237: IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, MAYBE_Whitelisting) { Remove the MAYBE_?
6 years, 4 months ago (2014-08-19 14:22:55 UTC) #2
Joao da Silva
https://codereview.chromium.org/486233002/diff/20001/chrome/browser/extensions/crx_installer_browsertest.cc File chrome/browser/extensions/crx_installer_browsertest.cc (right): https://codereview.chromium.org/486233002/diff/20001/chrome/browser/extensions/crx_installer_browsertest.cc#newcode237 chrome/browser/extensions/crx_installer_browsertest.cc:237: IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, MAYBE_Whitelisting) { On 2014/08/19 14:22:55, kalman wrote: > ...
6 years, 4 months ago (2014-08-20 07:37:11 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 4 months ago (2014-08-20 07:37:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/486233002/40001
6 years, 4 months ago (2014-08-20 07:38:27 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 10:45:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290805

Powered by Google App Engine
This is Rietveld 408576698