Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4278)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 486233002: Re-enabled a couple of ExtensionCrxInstallerTests: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 1ae57ddad5b8e7ebe08c5f80aceca5ec26423246..ba74ea903f01f1c516e6b477646bc02bf2c52b29 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -231,12 +231,10 @@ class ExtensionCrxInstallerTest : public ExtensionBrowserTest {
}
};
-#if defined(OS_CHROMEOS)
-#define MAYBE_Whitelisting DISABLED_Whitelisting
-#else
-#define MAYBE_Whitelisting Whitelisting
-#endif
-IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, MAYBE_Whitelisting) {
+// This test is skipped on ChromeOS because it requires the NPAPI,
+// which is not available on that platform.
+#if !defined(OS_CHROMEOS)
+IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, Whitelisting) {
std::string id = "hdgllgikmikobbofgnabhfimcfoopgnd";
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
@@ -248,6 +246,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, MAYBE_Whitelisting) {
EXPECT_FALSE(mock_prompt->confirmation_requested());
EXPECT_TRUE(service->GetExtensionById(id, false));
}
+#endif
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest,
GalleryInstallGetsExperimental) {
@@ -275,14 +274,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PlatformAppCrx) {
test_data_dir_.AppendASCII("minimal_platform_app.crx"), 1));
}
-// http://crbug.com/136397
-#if defined(OS_CHROMEOS)
-#define MAYBE_PackAndInstallExtension DISABLED_PackAndInstallExtension
-#else
-#define MAYBE_PackAndInstallExtension PackAndInstallExtension
-#endif
-IN_PROC_BROWSER_TEST_F(
- ExtensionCrxInstallerTest, MAYBE_PackAndInstallExtension) {
+IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PackAndInstallExtension) {
if (!FeatureSwitch::easy_off_store_install()->IsEnabled())
return;
@@ -336,14 +328,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, DoNotGrantScopes) {
false));
}
-// Off-store install cannot yet be disabled on Aura.
-#if defined(USE_AURA)
-#define MAYBE_AllowOffStore DISABLED_AllowOffStore
-#else
-#define MAYBE_AllowOffStore AllowOffStore
-#endif
-// Crashy: http://crbug.com/140893
-IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, DISABLED_AllowOffStore) {
+IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, AllowOffStore) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
const bool kTestData[] = {false, true};
@@ -363,8 +348,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, DISABLED_AllowOffStore) {
}
crx_installer->InstallCrx(test_data_dir_.AppendASCII("good.crx"));
- EXPECT_EQ(kTestData[i],
- WaitForExtensionInstall()) << kTestData[i];
+ // The |mock_prompt| will quit running the loop once the |crx_installer|
+ // is done.
+ content::RunMessageLoop();
EXPECT_EQ(kTestData[i], mock_prompt->did_succeed());
EXPECT_EQ(kTestData[i], mock_prompt->confirmation_requested()) <<
kTestData[i];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698