Do not switch the ICU locale when interacting with public session pods

ui/base/l10n/l10n_util.h

Index: ui/base/l10n/l10n_util.h
diff --git a/ui/base/l10n/l10n_util.h b/ui/base/l10n/l10n_util.h
index 507fb7342fd4cc1ffe3a872afa02c4227b612a5d..e2cb27d5c9c1efbc77315df8353ecf8c91b3e08d 100644
--- a/ui/base/l10n/l10n_util.h
+++ b/ui/base/l10n/l10n_util.h
@@ -40,7 +40,13 @@ UI_BASE_EXPORT bool CheckAndResolveLocale(const std::string& locale,
 // command line (--lang), second we try the value in the prefs file (passed in
 // as |pref_locale|), finally, we fall back on the system locale. We only return
 // a value if there's a corresponding resource DLL for the locale.  Otherwise,
-// we fall back to en-us.
+// we fall back to en-us. |set_icu_locale| determines whether the resulting
+// locale is set as the default ICU locale before returning it.
+UI_BASE_EXPORT std::string GetApplicationLocale(const std::string& pref_locale,
+                                                bool set_icu_locale);
+
+// Convenience version of GetApplicationLocale() that sets the resulting locale
+// as the default ICU locale before returning it.
 UI_BASE_EXPORT std::string GetApplicationLocale(const std::string& pref_locale);

[pneubeck (no reviews), 2014/08/19 15:09:30]

just for consideration:
shouldn't this be renamed to something that indicates the modification?
since this change will be merged, probably in a follow up.

[bartfab (slow), 2014/08/19 17:03:02]

I agree. It came as a very nasty surprise to me that a method named Get*() has a
side effect that actually sets the locale. However, I would definitely not want
to do any such renames in a CL that is meant for merging.

 
 // Returns true if a display name for |locale| is available in the locale