Do not switch the ICU locale when interacting with public session pods

ui/base/l10n/l10n_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains utility functions for dealing with localized
 // content.
 
 #ifndef UI_BASE_L10N_L10N_UTIL_H_
 #define UI_BASE_L10N_L10N_UTIL_H_
 
@@ skipping 22 matching lines @@
                                           std::string* resolved_locale);
 
 // This method is responsible for determining the locale as defined below. In
 // nearly all cases you shouldn't call this, rather use GetApplicationLocale
 // defined on browser_process.
 //
 // Returns the locale used by the Application.  First we use the value from the
 // command line (--lang), second we try the value in the prefs file (passed in
 // as |pref_locale|), finally, we fall back on the system locale. We only return
 // a value if there's a corresponding resource DLL for the locale.  Otherwise,
-// we fall back to en-us.
+// we fall back to en-us. |set_icu_locale| determines whether the resulting
+// locale is set as the default ICU locale before returning it.
+UI_BASE_EXPORT std::string GetApplicationLocale(const std::string& pref_locale,
+                                                bool set_icu_locale);
+
+// Convenience version of GetApplicationLocale() that sets the resulting locale
+// as the default ICU locale before returning it.
 UI_BASE_EXPORT std::string GetApplicationLocale(const std::string& pref_locale);

[pneubeck (no reviews), 2014/08/19 15:09:30]

just for consideration:
shouldn't this be renamed to something that indicates the modification?
since this change will be merged, probably in a follow up.

[bartfab (slow), 2014/08/19 17:03:02]

I agree. It came as a very nasty surprise to me that a method named Get*() has a
side effect that actually sets the locale. However, I would definitely not want
to do any such renames in a CL that is meant for merging.

 
 // Returns true if a display name for |locale| is available in the locale
 // |display_locale|.
 UI_BASE_EXPORT bool IsLocaleNameTranslated(const char* locale,
                                            const std::string& display_locale);
 
 // Given a locale code, return true if the OS is capable of supporting it.
 // For instance, Oriya is not well supported on Windows XP and we return
 // false for "or".
 bool IsLocaleSupportedByOS(const std::string& locale);
@@ skipping 133 matching lines @@
 // designer given constraints which might dependent on the language used.
 UI_BASE_EXPORT int GetLocalizedContentsWidthInPixels(int pixel_resource_id);
 
 UI_BASE_EXPORT const char* const* GetAcceptLanguageListForTesting();
 
 UI_BASE_EXPORT size_t GetAcceptLanguageListSizeForTesting();
 
 }  // namespace l10n_util
 
 #endif  // UI_BASE_L10N_L10N_UTIL_H_