chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h - Issue 486193004: Ash: Fix browser icon menu model lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

Issue 486193004: Ash: Fix browser icon menu model lifetime (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (menu-leak) simplify Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

index 3ddd4169591ac4e5e3b034fa192cea5078827708..293e2c145effb67491bd2b81232c327e66d0668f 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h

@@ -22,6 +22,8 @@ class ChromeLauncherAppMenuItemBrowser : public content::NotificationObserver,

const gfx::Image* icon,

Browser* browser,

bool has_leading_separator);

+ virtual ~ChromeLauncherAppMenuItemBrowser();

virtual bool IsActive() const OVERRIDE;

virtual bool IsEnabled() const OVERRIDE;

virtual void Execute(int event_flags) OVERRIDE;

« no previous file with comments | « ash/shelf/shelf_view.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc » ('j') | no next file with comments »