Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4467)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc

Issue 486193004: Ash: Fix browser icon menu model lifetime (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (menu-leak) simplify Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc
index 3f38fb4dfb4fac31fd7b702058dbaf17855c9159..26a75a8b145797767ae31c043b036c78eae39ace 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.cc
@@ -20,10 +20,13 @@ ChromeLauncherAppMenuItemBrowser::ChromeLauncherAppMenuItemBrowser(
bool has_leading_separator)
: ChromeLauncherAppMenuItem(title, icon, has_leading_separator),
browser_(browser) {
+ DCHECK(browser);
registrar_.Add(this,
chrome::NOTIFICATION_BROWSER_CLOSING,
content::Source<Browser>(browser));
}
+ChromeLauncherAppMenuItemBrowser::~ChromeLauncherAppMenuItemBrowser() {
+}
bool ChromeLauncherAppMenuItemBrowser::IsActive() const {
return browser_ == chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow());
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698