Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 486103002: Only add stubdata.c once on Windows (when icu_use_data_file_flag is set) (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
jungshik at Google, jam
CC:
chromium-reviews
Visibility:
Public.

Description

Only add stubdata.c once on Windows (when icu_use_data_file_flag is set) It defaults to 1 everywhere except android webview, but it looks like the windows condition wasn't updated after the switch. TBR=jshin@chromium.org R=jam@chromium.org BUG=404809 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291179

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M icu.gyp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
scottmg
https://codereview.chromium.org/486103002/diff/1/icu.gyp File icu.gyp (right): https://codereview.chromium.org/486103002/diff/1/icu.gyp#newcode329 icu.gyp:329: [ 'OS == "win" and icu_use_data_file_flag==0', { it's added ...
6 years, 4 months ago (2014-08-19 04:02:30 UTC) #1
jam
lgtm
6 years, 4 months ago (2014-08-21 20:48:48 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-21 20:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/486103002/1
6 years, 4 months ago (2014-08-21 20:50:11 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:50:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291179

Powered by Google App Engine
This is Rietveld 408576698