icu.gyp - Issue 486103002: Only add stubdata.c once on Windows (when icu_use_data_file_flag is set)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 486103002: Only add stubdata.c once on Windows (when icu_use_data_file_flag is set) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: icu.gyp

===================================================================

--- icu.gyp (revision 290482)

+++ icu.gyp (working copy)

@@ -326,7 +326,7 @@

[ 'use_system_icu==0 and want_separate_host_toolset==0', {

'toolsets': ['target'],

}],

- [ 'OS == "win"', {

+ [ 'OS == "win" and icu_use_data_file_flag==0', {

scottmg 2014/08/19 04:02:30 it's added in icudata at line 138 when icu_use_dat

'sources': [

'source/stubdata/stubdata.c',

« no previous file with comments | « no previous file | no next file » | no next file with comments »