Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 486083002: ServiceWorker: Introduce ServiceWorkerRegistrationObjectInfo for cleanup (Closed)

Created:
6 years, 4 months ago by nhiroki
Modified:
6 years, 4 months ago
Reviewers:
falken, nasko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Introduce ServiceWorkerRegistrationObjectInfo for cleanup This change introduces ServiceWorkerRegistrationObjectInfo which carries 'handle_id' and 'scope' for ServiceWorkerRegistration object in the renderer side over the IPC message, and removes unnecessary reference counting for ServiceWorker object on the registration sequence. BUG=384119, 396400 TEST=content_unittests --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py --debug http/tests/serviceworker Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290709

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -102 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +7 lines, -39 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 3 chunks +8 lines, -16 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_registration_handle_reference.h View 1 chunk +10 lines, -13 lines 0 comments Download
M content/child/service_worker/service_worker_registration_handle_reference.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 3 chunks +11 lines, -7 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nhiroki
Ptal, thanks!
6 years, 4 months ago (2014-08-19 04:06:43 UTC) #1
falken
code looks much nicer now :) lgtm
6 years, 4 months ago (2014-08-19 04:26:40 UTC) #2
nhiroki
+nasko@, could you review service_worker_messages.h? Thanks.
6 years, 4 months ago (2014-08-19 04:35:18 UTC) #3
nasko
IPC LGTM
6 years, 4 months ago (2014-08-19 17:13:29 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 4 months ago (2014-08-19 23:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/486083002/20001
6 years, 4 months ago (2014-08-19 23:02:13 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 00:10:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (20001) as 290709

Powered by Google App Engine
This is Rietveld 408576698