ServiceWorker: Introduce ServiceWorkerRegistrationObjectInfo for cleanup

content/browser/service_worker/service_worker_dispatcher_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/message_port_message_filter.h"
 #include "content/browser/message_port_service.h"
@@ skipping 309 matching lines @@
   if (!provider_host) {
     BadMessageReceived();
     return;
   }
   if (!provider_host->IsContextAlive())
     return;
   if (!provider_host->SetHostedVersionId(version_id))
     BadMessageReceived();
 }
 
-ServiceWorkerHandle* ServiceWorkerDispatcherHost::FindHandle(int provider_id,
-                                                             int64 version_id) {
-  for (IDMap<ServiceWorkerHandle, IDMapOwnPointer>::iterator iter(&handles_);
-       !iter.IsAtEnd();
-       iter.Advance()) {
-    ServiceWorkerHandle* handle = iter.GetCurrentValue();
-    DCHECK(handle);
-    if (handle->provider_id() == provider_id && handle->version() &&
-        handle->version()->version_id() == version_id) {
-      return handle;
-    }
-  }
-  return NULL;
-}
-
 ServiceWorkerRegistrationHandle*
 ServiceWorkerDispatcherHost::FindRegistrationHandle(int provider_id,
                                                     int64 registration_id) {
   for (IDMap<ServiceWorkerRegistrationHandle, IDMapOwnPointer>::iterator
            iter(&registration_handles_);
        !iter.IsAtEnd();
        iter.Advance()) {
     ServiceWorkerRegistrationHandle* handle = iter.GetCurrentValue();
     DCHECK(handle);
     if (handle->provider_id() == provider_id && handle->registration() &&
@@ skipping 12 matching lines @@
     int64 registration_id,
     int64 version_id) {
   if (!GetContext())
     return;
 
   if (status != SERVICE_WORKER_OK) {
     SendRegistrationError(thread_id, request_id, status);
     return;
   }
 
-  ServiceWorkerVersion* version = GetContext()->GetLiveVersion(version_id);
-  DCHECK(version);
-  DCHECK_EQ(registration_id, version->registration_id());
-  ServiceWorkerObjectInfo info;
-
-  ServiceWorkerHandle* handle = FindHandle(provider_id, version_id);
-  if (handle) {
-    DCHECK_EQ(thread_id, handle->thread_id());
-    info = handle->GetObjectInfo();
-    handle->IncrementRefCount();
-  } else {
-    scoped_ptr<ServiceWorkerHandle> new_handle = ServiceWorkerHandle::Create(
-        GetContext()->AsWeakPtr(), this, thread_id, provider_id, version);
-    info = new_handle->GetObjectInfo();
-    RegisterServiceWorkerHandle(new_handle.Pass());
-  }
-
   ServiceWorkerRegistration* registration =
       GetContext()->GetLiveRegistration(registration_id);
   DCHECK(registration);
 
-  ServiceWorkerRegistrationHandle* registration_handle =
+  ServiceWorkerRegistrationHandle* handle =
       FindRegistrationHandle(provider_id, registration_id);
-  int registration_handle_id = kInvalidServiceWorkerRegistrationHandleId;
-  if (registration_handle) {
-    registration_handle->IncrementRefCount();
-    registration_handle_id = registration_handle->handle_id();
+  ServiceWorkerRegistrationObjectInfo info;
+  if (handle) {
+    handle->IncrementRefCount();
+    info = handle->GetObjectInfo();
   } else {
     scoped_ptr<ServiceWorkerRegistrationHandle> new_handle(
         new ServiceWorkerRegistrationHandle(
             GetContext()->AsWeakPtr(), this, provider_id, registration));
-    registration_handle_id = new_handle->handle_id();
+    info = new_handle->GetObjectInfo();
     RegisterServiceWorkerRegistrationHandle(new_handle.Pass());
   }
 
   Send(new ServiceWorkerMsg_ServiceWorkerRegistered(
-      thread_id, request_id, registration_handle_id, info));
+      thread_id, request_id, info));
 }
 
 void ServiceWorkerDispatcherHost::OnWorkerScriptLoaded(int embedded_worker_id) {
   if (!GetContext())
     return;
   EmbeddedWorkerRegistry* registry = GetContext()->embedded_worker_registry();
   if (!registry->CanHandle(embedded_worker_id))
     return;
   registry->OnWorkerScriptLoaded(render_process_id_, embedded_worker_id);
 }
@@ skipping 137 matching lines @@
       status, &error_type, &error_message);
   Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError(
       thread_id, request_id, error_type, error_message));
 }
 
 ServiceWorkerContextCore* ServiceWorkerDispatcherHost::GetContext() {
   return context_wrapper_->context();
 }
 
 }  // namespace content