Add a regression test for http://crbug.com/29473

Add a regression test for http://crbug.com/29473

BUG=29473
TEST=it passes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34504

[tony, 2009-12-11 22:00:35]

LGTM

http://codereview.chromium.org/486037/diff/1/2
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/486037/diff/1/2#newcode300
chrome/browser/browser_focus_uitest.cc:300: for (int j = 0; j < 25; j++) {
Nit: Do we really need to run 25 times?  Looks like this is inside a loop of 3
already.  *shrug*

[Evan Stade, 2009-12-11 22:11:59]

http://codereview.chromium.org/486037/diff/1/2
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/486037/diff/1/2#newcode300
chrome/browser/browser_focus_uitest.cc:300: for (int j = 0; j < 25; j++) {
On 2009/12/11 22:00:35, tony wrote:
> Nit: Do we really need to run 25 times?  Looks like this is inside a loop of 3
> already.  *shrug*

it's a loop of 5, 5 times. I could reduce it, but the bug had the issue that the
first couple ctrl+tabs wouldn't trigger the issue, so I thought better safe than
sorry. It still executes pretty quickly (~1 second).

[tony, 2009-12-11 22:15:28]

<1s is fast, seems fine to keep it at 25.

[Evan Stade, 2009-12-11 22:26:43]

(actually, it takes me 3.399s, I can reduce it if you want, but we have lots of
places that just wait around for a couple seconds, so this seems not too bad)

[jcampan, 2009-12-11 22:41:34]

LGTM but I think it'd be better to lower the 25 iterations to a value that gets
the test time around 1 second if you can.

[Evan Stade, 2009-12-14 22:02:20]

ok, I was more careful with my experiments. Without any changes, this test takes
about 2.5 seconds on my machine. Most of that time is spinning up and shutting
down of the test, not running of the test.  With these changes, it seems to be
sitting at ~5 seconds (I don't know why it changed from 3.5 to 5 over the
weekend, but this is not a controlled environment). Lowering the iterations to
15 gets it to about 4 (1.5 second slowdown). I'll go with that.