Add a regression test for http://crbug.com/29473

chrome/browser/browser_focus_uitest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "base/message_loop.h"
 #include "base/ref_counted.h"
 #include "chrome/browser/automation/ui_controls.h"
 #include "chrome/browser/browser.h"
@@ skipping 18 matching lines @@
 #endif
 
 #if defined(OS_LINUX)
 #include "chrome/browser/gtk/view_id_util.h"
 #endif
 
 #if defined(OS_LINUX)
 // For some reason we hit an external DNS lookup in this test in Linux but not
 // on Windows. TODO(estade): investigate.
 #define MAYBE_FocusTraversalOnInterstitial DISABLED_FocusTraversalOnInterstitial
+// TODO(jcampan): http://crbug.com/23683
+#define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage
 #else
 #define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial
+#define MAYBE_TabsRememberFocusFindInPage TabsRememberFocusFindInPage
 #endif
 
 namespace {
 
 // The delay waited in some cases where we don't have a notifications for an
 // action we take.
 const int kActionDelayMs = 500;
 
 const wchar_t kSimplePage[] = L"files/focus/page_with_focus.html";
 const wchar_t kStealFocusPage[] = L"files/focus/page_steals_focus.html";
@@ skipping 231 matching lines @@
 
     // Now come back to the tab and check the right view is focused.
     for (int j = 0; j < 5; j++) {
       // Activate the tab.
       browser()->SelectTabContentsAt(j, true);
 
       ViewID vid = kFocusPage[i][j] ? VIEW_ID_TAB_CONTAINER_FOCUS_VIEW :
                                       VIEW_ID_LOCATION_BAR;
       ASSERT_TRUE(IsViewFocused(vid));
     }
+
+    gfx::NativeWindow window = browser()->window()->GetNativeHandle();
+    browser()->SelectTabContentsAt(0, true);
+    // Try the above, but with ctrl+tab. Since tab normally changes focus,
+    // this has regressed in the past. Loop through several times to be sure.
+    for (int j = 0; j < 25; j++) {

[tony, 2009/12/11 22:00:35]

Nit: Do we really need to run 25 times?  Looks like this is inside a loop of 3
already.  *shrug*

[Evan Stade, 2009/12/11 22:11:59]

it's a loop of 5, 5 times. I could reduce it, but the bug had the issue that the
first couple ctrl+tabs wouldn't trigger the issue, so I thought better safe than
sorry. It still executes pretty quickly (~1 second).

+      ViewID vid = kFocusPage[i][j % 5] ? VIEW_ID_TAB_CONTAINER_FOCUS_VIEW :
+                                          VIEW_ID_LOCATION_BAR;
+      ASSERT_TRUE(IsViewFocused(vid));
+
+      ui_controls::SendKeyPressNotifyWhenDone(window, base::VKEY_TAB, true,
+                                              false, false,
+                                              new MessageLoop::QuitTask());
+      ui_test_utils::RunMessageLoop();
+    }
+
+    // As above, but with ctrl+shift+tab.
+    browser()->SelectTabContentsAt(4, true);
+    for (int j = 24; j >= 0; --j) {
+      ViewID vid = kFocusPage[i][j % 5] ? VIEW_ID_TAB_CONTAINER_FOCUS_VIEW :
+                                          VIEW_ID_LOCATION_BAR;
+      ASSERT_TRUE(IsViewFocused(vid));
+
+      ui_controls::SendKeyPressNotifyWhenDone(window, base::VKEY_TAB, true,
+                                              true, false,
+                                              new MessageLoop::QuitTask());
+      ui_test_utils::RunMessageLoop();
+    }
   }
 }
 
 // Tabs remember focus with find-in-page box.
-// TODO(jcampan): http://crbug.com/23683 Disabled because it fails on Linux.
-IN_PROC_BROWSER_TEST_F(BrowserFocusTest, DISABLED_TabsRememberFocusFindInPage) {
+IN_PROC_BROWSER_TEST_F(BrowserFocusTest, MAYBE_TabsRememberFocusFindInPage) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to our test page.
   GURL url = server->TestServerPageW(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   browser()->Find();
   ui_test_utils::FindInPage(browser()->GetSelectedTabContents(),
                             ASCIIToUTF16("a"), true, false, NULL);
   ASSERT_TRUE(IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
@@ skipping 408 matching lines @@
 
   // Open a regular page, crash, reload.
   ui_test_utils::NavigateToURL(browser(), server->TestServerPageW(kSimplePage));
   ui_test_utils::CrashTab(browser()->GetSelectedTabContents());
   browser()->Reload();
   ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
   // Focus should now be on the tab contents.
   browser()->ShowDownloadsTab();
   ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW));
 }