Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 485943004: Revert 290320 "Refactor pooling logic into a helper method" (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290320 "Refactor pooling logic into a helper method" Leaks (see bug). Actually reverting the re-land this time. BUG=404833 > Refactor pooling logic into a helper method > Disable pooling when there are cert errors. > Disable pooling when pinning does not match for the new host. > > BUG=398925 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289433 > > Review URL: https://codereview.chromium.org/425803014 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -440 lines) Patch
M trunk/src/net/http/http_network_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/http/http_response_body_drainer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/net/quic/quic_client_session.h View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/net/quic/quic_client_session.cc View 5 chunks +22 lines, -6 lines 0 comments Download
M trunk/src/net/quic/quic_client_session_test.cc View 7 chunks +10 lines, -54 lines 0 comments Download
M trunk/src/net/quic/quic_http_stream_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/quic/quic_stream_factory.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory_test.cc View 5 chunks +4 lines, -144 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.h View 4 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.cc View 4 chunks +12 lines, -43 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool.h View 3 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_unittest.cc View 4 chunks +3 lines, -107 lines 0 comments Download
M trunk/src/net/spdy/spdy_test_utils.h View 2 chunks +0 lines, -18 lines 0 comments Download
M trunk/src/net/spdy/spdy_test_utils.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-18 22:46:33 UTC) #1
viettrungluu
6 years, 4 months ago (2014-08-18 22:47:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r290386.

Powered by Google App Engine
This is Rietveld 408576698