Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: trunk/src/net/socket/ssl_client_socket_pool_unittest.cc

Issue 485943004: Revert 290320 "Refactor pooling logic into a helper method" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/quic/quic_stream_factory_test.cc ('k') | trunk/src/net/spdy/spdy_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/socket/ssl_client_socket_pool_unittest.cc
===================================================================
--- trunk/src/net/socket/ssl_client_socket_pool_unittest.cc (revision 290385)
+++ trunk/src/net/socket/ssl_client_socket_pool_unittest.cc (working copy)
@@ -22,7 +22,6 @@
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_server_properties_impl.h"
-#include "net/http/transport_security_state.h"
#include "net/proxy/proxy_service.h"
#include "net/socket/client_socket_handle.h"
#include "net/socket/client_socket_pool_histograms.h"
@@ -193,7 +192,6 @@
http_server_properties_.GetWeakPtr();
params.enable_spdy_compression = false;
params.spdy_default_protocol = GetParam();
- params.transport_security_state = new TransportSecurityState();
return new HttpNetworkSession(params);
}
@@ -1259,7 +1257,8 @@
EXPECT_FALSE(tunnel_handle->socket()->IsConnected());
}
-TEST_P(SSLClientSocketPoolTest, IPPooling) {
+// TODO(rch): re-enable this.
+TEST_P(SSLClientSocketPoolTest, DISABLED_IPPooling) {
const int kTestPort = 80;
struct TestHosts {
std::string name;
« no previous file with comments | « trunk/src/net/quic/quic_stream_factory_test.cc ('k') | trunk/src/net/spdy/spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698