Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 485893007: Rename components/breakpad to components/crash. (Closed)

Created:
6 years, 4 months ago by Robert Sesek
Modified:
6 years, 3 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, chromoting-reviews_chromium.org, tfarina, jam, jochen+watch_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/abcd8100a58d4e5ba55f4ec2e5f394e0aa6a3f33 Cr-Commit-Position: refs/heads/master@{#292162}

Patch Set 1 #

Patch Set 2 : Fix Android #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Total comments: 2

Patch Set 5 : Rebase + iOS tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -5750 lines) Patch
M PRESUBMIT_test.py View 1 chunk +1 line, -1 line 0 comments Download
M WATCHLISTS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_breakpad_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/main.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M components/OWNERS View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
D components/breakpad.gypi View 1 chunk +0 lines, -233 lines 0 comments Download
D components/breakpad/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/breakpad/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/breakpad/app/BUILD.gn View 1 chunk +0 lines, -69 lines 0 comments Download
D components/breakpad/app/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/breakpad/app/breakpad_client.h View 1 chunk +0 lines, -143 lines 0 comments Download
D components/breakpad/app/breakpad_client.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D components/breakpad/app/breakpad_linux.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/breakpad/app/breakpad_linux.cc View 1 chunk +0 lines, -1615 lines 0 comments Download
D components/breakpad/app/breakpad_linux_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/breakpad/app/breakpad_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/breakpad/app/breakpad_mac.mm View 1 chunk +0 lines, -279 lines 0 comments Download
D components/breakpad/app/breakpad_mac_stubs.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D components/breakpad/app/breakpad_win.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/breakpad/app/breakpad_win.cc View 1 chunk +0 lines, -609 lines 0 comments Download
D components/breakpad/app/crash_keys_win.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/breakpad/app/crash_keys_win.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D components/breakpad/app/crash_keys_win_unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D components/breakpad/app/hard_error_handler_win.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/breakpad/app/hard_error_handler_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D components/breakpad/browser/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D components/breakpad/browser/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/breakpad/browser/crash_dump_manager_android.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/breakpad/browser/crash_dump_manager_android.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D components/breakpad/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -93 lines 0 comments Download
D components/breakpad/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -436 lines 0 comments Download
D components/breakpad/tools/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/breakpad/tools/crash_service.h View 1 chunk +0 lines, -125 lines 0 comments Download
D components/breakpad/tools/crash_service.cc View 1 chunk +0 lines, -488 lines 0 comments Download
D components/breakpad/tools/dmp2minidump.py View 1 chunk +0 lines, -51 lines 0 comments Download
D components/breakpad/tools/generate_breakpad_symbols.py View 1 chunk +0 lines, -259 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
A + components/crash.gypi View 1 11 chunks +55 lines, -55 lines 0 comments Download
A + components/crash/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/app/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/app/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/app/breakpad_client.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + components/crash/app/breakpad_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/app/breakpad_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/app/breakpad_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/app/breakpad_linux_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/crash/app/breakpad_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/app/breakpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/app/breakpad_mac_stubs.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/app/breakpad_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/app/breakpad_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/crash/app/crash_keys_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/app/crash_keys_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/app/crash_keys_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/crash/app/hard_error_handler_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/app/hard_error_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/browser/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/browser/crash_dump_manager_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/browser/crash_handler_host_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/browser/crash_handler_host_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/tools/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/tools/crash_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/tools/crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/tools/dmp2minidump.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/tools/generate_breakpad_symbols.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_breakpad_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/tools/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/content_shell_crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Robert Sesek
blundell: Mind taking a look at this, since jochen@ is out? The change is mostly ...
6 years, 3 months ago (2014-08-25 14:50:25 UTC) #1
blundell
lgtm https://codereview.chromium.org/485893007/diff/80001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/485893007/diff/80001/components/components_tests.gyp#newcode480 components/components_tests.gyp:480: ['include', '^bookmarks/'], please add crash here in case ...
6 years, 3 months ago (2014-08-26 08:06:07 UTC) #2
Robert Sesek
Thanks! https://codereview.chromium.org/485893007/diff/80001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/485893007/diff/80001/components/components_tests.gyp#newcode480 components/components_tests.gyp:480: ['include', '^bookmarks/'], On 2014/08/26 08:06:06, blundell wrote: > ...
6 years, 3 months ago (2014-08-26 15:14:51 UTC) #3
Robert Sesek
rsesek@chromium.org changed reviewers: + darin@chromium.org
6 years, 3 months ago (2014-08-26 15:15:24 UTC) #4
Robert Sesek
Darin: Could I get an OWNERS stamp for this large file move?
6 years, 3 months ago (2014-08-26 15:15:24 UTC) #5
Robert Sesek
On 2014/08/26 15:15:24, rsesek wrote: > Darin: Could I get an OWNERS stamp for this ...
6 years, 3 months ago (2014-08-27 16:12:37 UTC) #6
Robert Sesek
Committed patchset #5 (id:100001) to pending queue manually as 55b8563.
6 years, 3 months ago (2014-08-27 16:13:16 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:03 UTC) #8
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/abcd8100a58d4e5ba55f4ec2e5f394e0aa6a3f33
Cr-Commit-Position: refs/heads/master@{#292162}

Powered by Google App Engine
This is Rietveld 408576698