Issue 485843002: Add logspam to help diagnose flaky tests

Issue 485843002: Add logspam to help diagnose flaky tests (Closed)

Created:
6 years, 4 months ago by aboxhall

Modified:
6 years, 3 months ago

Reviewers:
David Tseng, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add logspam to help diagnose flaky tests BUG=391279, 385701, 353039, 379927, 384673

Patch Set 2 : Log --> LOG #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -6 lines)			Patch
M	chrome/browser/extensions/api/automation_internal/automation_util.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/renderer/resources/extensions/automation/automation_node.js	View	1	4 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/renderer/resources/extensions/automation_custom_bindings.js	View	1	5 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/automation/tests/tabs/common.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/automation/tests/tabs_automation_boolean/common.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

David Tseng

lgtm https://codereview.chromium.org/485843002/diff/1/chrome/renderer/resources/extensions/automation_custom_bindings.js File chrome/renderer/resources/extensions/automation_custom_bindings.js (left): https://codereview.chromium.org/485843002/diff/1/chrome/renderer/resources/extensions/automation_custom_bindings.js#oldcode105 chrome/renderer/resources/extensions/automation_custom_bindings.js:105: return; Also put logging in performAction?

6 years, 4 months ago (2014-08-18 22:55:45 UTC) #2

aboxhall

On 2014/08/18 22:55:45, David Tseng wrote: > lgtm > > https://codereview.chromium.org/485843002/diff/1/chrome/renderer/resources/extensions/automation_custom_bindings.js > File chrome/renderer/resources/extensions/automation_custom_bindings.js (left): ...

6 years, 4 months ago (2014-08-19 14:42:43 UTC) #3

not at google - send to devlin

lgtm though is "debug" log a thing? Eh. modulo changing all console.log to logging.Log. (the ...

6 years, 4 months ago (2014-08-19 14:47:48 UTC) #5

aboxhall

https://codereview.chromium.org/485843002/diff/1/chrome/renderer/resources/extensions/automation/automation_node.js File chrome/renderer/resources/extensions/automation/automation_node.js (right): https://codereview.chromium.org/485843002/diff/1/chrome/renderer/resources/extensions/automation/automation_node.js#newcode117 chrome/renderer/resources/extensions/automation/automation_node.js:117: console.log('dispatching ' + eventType + ' on ' + ...

6 years, 4 months ago (2014-08-19 15:04:23 UTC) #6

aboxhall

This has been committed: http://src.chromium.org/viewvc/chrome?revision=290561&view=revision (I messed up and the change didn't get updated, but ...

6 years, 4 months ago (2014-08-19 15:57:03 UTC) #7

David Tseng

On 2014/08/19 15:57:03, aboxhall_ooo_until_oct_6 wrote: > This has been committed: > http://src.chromium.org/viewvc/chrome?revision=290561&view=revision > (I messed ...

6 years, 3 months ago (2014-09-10 21:38:05 UTC) #8

David Tseng

6 years, 3 months ago (2014-09-10 21:40:22 UTC) #9

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/561923002/ by dtseng@chromium.org.

The reason for reverting is: No longer needed since AutomationApiTests have been
running for some time without flaking..

Expand Messages | Collapse Messages