chrome/test/data/extensions/api_test/automation/tests/tabs/common.js - Issue 485843002: Add logspam to help diagnose flaky tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/common.js

Issue 485843002: Add logspam to help diagnose flaky tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Log --> LOG Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/automation_custom_bindings.js ('k') | chrome/test/data/extensions/api_test/automation/tests/tabs_automation_boolean/common.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/common.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/common.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/common.js

index af464a2573a079b980d4cbcb2470a88c6610d6b7..5e41c98e8e3acd016f4bfb135e2c548b18ae31e6 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/common.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/common.js

@@ -24,10 +24,15 @@ function setUpAndRunTests(allTests) {

chrome.automation.getTree(function (returnedRootNode) {

rootNode = returnedRootNode;

if (rootNode.attributes.docLoaded) {

+ console.log('In getTree() callback: ' +

+ 'docLoaded attr already true; running tests');

chrome.test.runTests(allTests);

return;

}

+ console.log('In getTree() callback: ' +

+ 'docLoaded false; waiting for loadComplete');

rootNode.addEventListener('loadComplete', function() {

+ console.log('loadComplete received; running tests.');

chrome.test.runTests(allTests);

});