Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 485833005: Image decoding: Remove deprecated image caching code (Closed)

Created:
6 years, 4 months ago by Alpha Left Google
Modified:
6 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Image decoding: Remove deprecated image caching code ImageDecodingStore was used to cache images for impl side painting on Android. Now impl side painting is using image cache in Skia. ImageDecodingStore is only used to cache decoders. Deleted 1k lines of code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -981 lines) Patch
M Source/platform/blink_platform.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/platform/graphics/DiscardablePixelRef.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/platform/graphics/DiscardablePixelRef.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 10 chunks +9 lines, -117 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.cpp View 13 chunks +8 lines, -147 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStoreTest.cpp View 8 chunks +8 lines, -305 lines 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/ImageFrameGeneratorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/platform/graphics/ScaledImageFragment.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/platform/graphics/ScaledImageFragment.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/platform/graphics/test/MockDiscardablePixelRef.h View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
6 years, 4 months ago (2014-08-21 20:58:34 UTC) #1
Stephen White
LGTM! (bots willing)
6 years, 4 months ago (2014-08-21 21:55:26 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-21 23:14:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/485833005/1
6 years, 4 months ago (2014-08-21 23:15:00 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 00:13:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180746

Powered by Google App Engine
This is Rietveld 408576698