Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 485723004: Page info not closing on non-Mac desktop when close button icon clicked. (Closed)

Created:
6 years, 4 months ago by jww
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, markusheintz_
Project:
chromium
Visibility:
Public.

Description

Page info not closing on non-Mac desktop when close button icon clicked. This fixes the page info close icon so when it is clicked, it closes the dialog properly. This was a regression introduced by https://codereview.chromium.org/473643002/ where the widget's Close() method was accidentally moved inside of a conditional in the button handler when it really should have been executed on all button presses. This moves the Close() method outside the conditional so it properly closes the dialog. BUG=404963 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jww
6 years, 4 months ago (2014-08-19 19:15:25 UTC) #1
jww
The CQ bit was checked by jww@chromium.org
6 years, 4 months ago (2014-08-19 19:15:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/485723004/1
6 years, 4 months ago (2014-08-19 19:16:30 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-19 20:40:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 290659
6 years, 4 months ago (2014-08-19 20:45:57 UTC) #5
Peter Kasting
6 years, 4 months ago (2014-08-21 21:22:34 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698