Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473643002: Add button to page info to revoke user certificate decisions. (Closed)

Created:
6 years, 4 months ago by jww
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina, markusheintz_, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add button to page info to revoke user certificate decisions. (Re-commit of https://codereview.chromium.org/418133012/) Currently, if a user clicks 'proceed' through an SSL interstitial, their only way to revoke this decision is to restart their browser session. This commit provides an explicit button in the page info to revoke this decision if the user is using the remember certificate error decisions experiment. Since decisions are remembered across browser restarts for these users, it's important to provide them with a mechanism to revoke their decision later. BUG=262615 NOTRY=true TBR=tedchoc@chromium.org,rsesek@chromium.org,jam@chromium.org,pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -308 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 7 chunks +36 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.h View 2 chunks +25 lines, -2 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.cc View 6 chunks +54 lines, -3 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc View 6 chunks +46 lines, -17 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 4 chunks +34 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 7 chunks +67 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 9 chunks +50 lines, -40 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.h View 5 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 6 chunks +46 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 3 chunks +8 lines, -4 lines 0 comments Download
D content/browser/ssl/ssl_host_state.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/browser/ssl/ssl_host_state.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +17 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/ssl_host_state_delegate.h View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jww
The CQ bit was checked by jww@chromium.org
6 years, 4 months ago (2014-08-13 21:16:58 UTC) #1
jww
The CQ bit was unchecked by jww@chromium.org
6 years, 4 months ago (2014-08-13 21:17:21 UTC) #2
jww
The CQ bit was checked by jww@chromium.org
6 years, 4 months ago (2014-08-13 21:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/473643002/1
6 years, 4 months ago (2014-08-13 21:19:42 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 21:22:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289382

Powered by Google App Engine
This is Rietveld 408576698