Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 485523002: Implement *multiply*() methods in DOMMatrix. (Closed)

Created:
6 years, 4 months ago by zino
Modified:
6 years, 4 months ago
Reviewers:
pdr., krit, Rik
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement *multiply*() methods in DOMMatrix. The methods multiply the specified other matrix to the current matrix (pre or post). The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180857

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : pdr's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
A LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrix.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrix.cpp View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrix.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
zino
PTAL
6 years, 4 months ago (2014-08-17 16:39:43 UTC) #1
krit
On 2014/08/17 16:39:43, zino wrote: > PTAL It looks good to me. I would like ...
6 years, 4 months ago (2014-08-17 18:28:30 UTC) #2
zino
On 2014/08/17 18:28:30, krit wrote: > On 2014/08/17 16:39:43, zino wrote: > > PTAL > ...
6 years, 4 months ago (2014-08-18 01:04:55 UTC) #3
Rik
lgtm
6 years, 4 months ago (2014-08-22 09:12:48 UTC) #4
krit
lgtm
6 years, 4 months ago (2014-08-22 14:15:22 UTC) #5
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 4 months ago (2014-08-24 09:23:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/485523002/60001
6 years, 4 months ago (2014-08-24 09:24:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-24 10:25:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-24 11:27:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/22590)
6 years, 4 months ago (2014-08-24 11:27:13 UTC) #10
pdr.
https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html File LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html (right): https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html#newcode1 LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html:1: <!DOCTYPE html> This should not be a pixel test. ...
6 years, 4 months ago (2014-08-25 03:13:01 UTC) #11
zino
On 2014/08/25 03:13:01, pdr wrote: > https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html > File LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html (right): > > https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html#newcode1 > ...
6 years, 4 months ago (2014-08-25 03:18:24 UTC) #12
pdr.
On 2014/08/25 03:18:24, zino wrote: > On 2014/08/25 03:13:01, pdr wrote: > > > https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html ...
6 years, 4 months ago (2014-08-25 03:28:43 UTC) #13
zino
Dear @pdr, I addressed your comment. Could you review again? https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html File LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html (right): https://codereview.chromium.org/485523002/diff/80001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-multiply.html#newcode1 ...
6 years, 4 months ago (2014-08-25 12:24:12 UTC) #14
pdr.
On 2014/08/25 12:24:12, zino wrote: > Dear @pdr, > > I addressed your comment. > ...
6 years, 4 months ago (2014-08-25 16:53:50 UTC) #15
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-08-25 16:54:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/485523002/120001
6 years, 4 months ago (2014-08-25 16:54:33 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 16:57:21 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (120001) as 180857

Powered by Google App Engine
This is Rietveld 408576698