Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: Tools/GardeningServer/ui/test/ct-commit-list-tests.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: names Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-commit-list-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-commit-list-tests.html b/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
index 9b18cb160be85646c9d14f53b305bdc635ab127b..83f85ff1521bf80b56df3747453bb6396731da13 100644
--- a/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
@@ -6,7 +6,7 @@ found in the LICENSE file.
<link rel="import" href="../ct-commit-list.html">
-<link rel="import" href="../../model/ct-commit-log-mock.html">
+<link rel="import" href="../../model/ct-commit-list-mock.html">
<script>
(function () {
@@ -23,19 +23,7 @@ describe('ct-commit-list', function() {
describe('commit list UI', function() {
beforeEach(function(done) {
- var repos = [
- { commits: [ new CTCommitMock(), new CTCommitMock() ],
- expanded: false },
- { commits: [ new CTCommitMock(), new CTCommitMock() ],
- expanded: false }
- ];
-
- list.commitList = {
- repositories: function() {
- return repos;
- }
- };
-
+ list.commitList = new CTCommitListMock();
setTimeout(done);
});
@@ -46,13 +34,12 @@ describe('ct-commit-list', function() {
describe('expanded test', function() {
beforeEach(function(done) {
- list.commitList.repositories().first().expanded = true;
- list.commitList.repositories().last().expanded = true;
+ list.commitList.repositories.first().expanded = true;
setTimeout(done);
});
- it('should show commits when expanded', function() {
- assert.lengthOf(list.shadowRoot.querySelectorAll('ct-commit'), 4);
+ it('should show commit when expanded', function() {
+ assert.lengthOf(list.shadowRoot.querySelectorAll('ct-commit'), 1);
});
});
});
« no previous file with comments | « Tools/GardeningServer/ui/ct-unexpected-failures.html ('k') | Tools/GardeningServer/ui/test/ct-failure-card-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698