Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Unified Diff: Tools/GardeningServer/ui/ct-unexpected-failures.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: names Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-unexpected-failures.html
diff --git a/Tools/GardeningServer/ui/ct-unexpected-failures.html b/Tools/GardeningServer/ui/ct-unexpected-failures.html
index 2be627ddb52e5d4dd9c87d6c193e65386a7eb10c..b21bccf9bbd688d1b89739ba078cafd33f37b88a 100644
--- a/Tools/GardeningServer/ui/ct-unexpected-failures.html
+++ b/Tools/GardeningServer/ui/ct-unexpected-failures.html
@@ -40,14 +40,14 @@ found in the LICENSE file.
</style>
<ct-failure-analyzer id="analyzer" failures="{{ failures }}" builderLatestRevisions="{{ builderLatestRevisions }}" lastUpdateDate="{{ lastUpdateDate }}"></ct-failure-analyzer>
<div class="toolbar">
- <ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" revisionLog="{{ revisionLog }}" tree="{{ tree }}"></ct-revision-details>
+ <ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-revision-details>
<a href="https://code.google.com/p/chromium/wiki/UsefulURLs">Useful URLs</a>
</div>
<ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
<ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
<ct-party-time failures="{{ failures }}" tree="{{ tree }}"></ct-party-time>
- <ct-failure-stream category="default" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
- <ct-failure-stream category="snoozed" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-failure-stream category="default" groups="{{ failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-failure-stream category="snoozed" groups="{{ failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
</template>
<script>
(function() {
@@ -57,7 +57,7 @@ found in the LICENSE file.
tree: '',
created: function() {
- this.revisionLog = new CTCommitLog(),
+ this.commitLog = new CTCommitLog(),
this._updater = new CTScheduledUpdater(this.update.bind(this), kUpdateFrequency);
this.treeStatuses = {};
@@ -73,7 +73,7 @@ found in the LICENSE file.
update: function() {
// FIXME: These shouldn't update if there's already an update in progress.
- this.revisionLog.update();
+ this.commitLog.update();
this.$.analyzer.update();
Object.keys(this.treeStatuses, function(tree, status) {
status.update();
« no previous file with comments | « Tools/GardeningServer/ui/ct-revision-details.html ('k') | Tools/GardeningServer/ui/test/ct-commit-list-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698