Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: names Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | Tools/GardeningServer/ui/ct-failure-stream.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index 5cb2a2c86d275615bf8a92a37b1a22d021cedabb..d2c82dd98852c53ae2c7a54c57c8630007b86d28 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -11,7 +11,7 @@ found in the LICENSE file.
<link rel="import" href="../bower_components/paper-dialog/paper-dialog-transition.html">
<link rel="import" href="../bower_components/paper-input/paper-input.html">
-<polymer-element name="ct-failure-card" attributes="group commits tree bug">
+<polymer-element name="ct-failure-card" attributes="group commitLog tree bug">
<template>
<style>
:host {
@@ -68,7 +68,7 @@ found in the LICENSE file.
<ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
<div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
- <ct-commit-list commitList="{{ _commits() }}"></ct-commit-list>
+ <ct-commit-list commitList="{{ _commitList }}"></ct-commit-list>
</div>
<div id="buttons">
<paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
@@ -96,8 +96,14 @@ found in the LICENSE file.
<script>
Polymer({
group: null,
- commits: null,
+ commitLog: null,
tree: '',
+ _commitList: null,
+
+ observe: {
+ group: '_updateCommitList',
+ commitLog: '_updateCommitList'
+ },
examine: function() {
this.fire('ct-examine-failures', this.group);
@@ -111,10 +117,9 @@ found in the LICENSE file.
this.group.unsnooze();
},
- _commits: function() {
- if (!this.group)
- return undefined;
- return this.group.commitList(this.commits);
+ _updateCommitList: function() {
+ this._commitList = this.group ?
+ this.group.commitList(this.commitLog) : undefined;
},
linkBug: function() {
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | Tools/GardeningServer/ui/ct-failure-stream.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698