Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: Tools/GardeningServer/ui/ct-commit-list.html

Issue 485253004: [Sheriff-o-matic] Remove race condition on the commit list. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: names Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-commit-list.html
diff --git a/Tools/GardeningServer/ui/ct-commit-list.html b/Tools/GardeningServer/ui/ct-commit-list.html
index 287946a6797003523ee515f42f8889fb0ccb159a..501f65eefb791c4db86789a90379e1294a27053b 100644
--- a/Tools/GardeningServer/ui/ct-commit-list.html
+++ b/Tools/GardeningServer/ui/ct-commit-list.html
@@ -20,7 +20,7 @@ found in the LICENSE file.
display: block;
}
</style>
- <template repeat="{{ repository in commitList | _repositories }}">
+ <template repeat="{{ repository in commitList.repositories }}">
<div class="repository-info">
{{ repository.name }} {{ repository.range }}
<paper-icon-button icon="unfold-more"
@@ -35,21 +35,9 @@ found in the LICENSE file.
</template>
<script>
Polymer({
- repositories: undefined,
-
- created: function() {
- this.repositories = [];
- },
-
- _repositories: function() {
- if (this.commitList)
- this.repositories = this.commitList.repositories();
- return this.repositories;
- },
-
_toggle: function(event, detail, sender, target) {
var repo = sender.getAttribute('repository');
- var r = this.repositories.find(function(item) {
+ var r = this.commitList.repositories.find(function(item) {
return item.name === repo;
});
r.expanded = !r.expanded;
« no previous file with comments | « Tools/GardeningServer/model/test/ct-commit-log-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-card.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698