tools/gn/ninja_binary_target_writer_unittest.cc - Issue 48523006: GN: Separately track labels and origins for lists of stuff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer_unittest.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_binary_target_writer_unittest.cc

diff --git a/tools/gn/ninja_binary_target_writer_unittest.cc b/tools/gn/ninja_binary_target_writer_unittest.cc

index 0bf47229910549dd27abd73b9536dad69de1b4e7..a7de4a118fa7e51bd05814ad135ff4c08b75f1f5 100644

--- a/tools/gn/ninja_binary_target_writer_unittest.cc

+++ b/tools/gn/ninja_binary_target_writer_unittest.cc

@@ -50,7 +50,7 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {

// A shared library that depends on the source set.

Target shlib_target(setup.settings(), Label(SourceDir("//foo/"), "shlib"));

shlib_target.set_output_type(Target::SHARED_LIBRARY);

- shlib_target.deps().push_back(&target);

+ shlib_target.deps().push_back(LabelTargetPair(&target));

shlib_target.OnResolved();

{

« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_group_target_writer.cc » ('j') | no next file with comments »