Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 485203002: Fix the issue in about:net-internals that causes clicking on a column (Closed)

Created:
6 years, 4 months ago by mmenke
Modified:
6 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews, eroman, arv+watch_chromium.org, mmenke
Project:
chromium
Visibility:
Public.

Description

Fix issue in about:net-internals with clicking on a column that causes the current filter to be cleared, instead of modified. BUG=405089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290964

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/browser/resources/net_internals/source_filter_parser.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/events_view.js View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mmenke
6 years, 4 months ago (2014-08-20 16:58:19 UTC) #1
eroman
lgtm
6 years, 4 months ago (2014-08-20 18:05:14 UTC) #2
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 4 months ago (2014-08-20 18:05:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/485203002/40001
6 years, 4 months ago (2014-08-20 18:08:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-20 20:02:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 21:33:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/3827)
6 years, 4 months ago (2014-08-20 21:33:56 UTC) #7
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 4 months ago (2014-08-20 21:35:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/485203002/40001
6 years, 4 months ago (2014-08-20 21:37:12 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 23:33:09 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 00:45:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 290964

Powered by Google App Engine
This is Rietveld 408576698