Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9608)

Unified Diff: chrome/test/data/webui/net_internals/events_view.js

Issue 485203002: Fix the issue in about:net-internals that causes clicking on a column (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/net_internals/source_filter_parser.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/net_internals/events_view.js
diff --git a/chrome/test/data/webui/net_internals/events_view.js b/chrome/test/data/webui/net_internals/events_view.js
index 2822bc19edb125a703ba3f1bd12f68eb4523c223..0c0424bf2928e6d1c86e4c08bf36d9c11e5873f0 100644
--- a/chrome/test/data/webui/net_internals/events_view.js
+++ b/chrome/test/data/webui/net_internals/events_view.js
@@ -213,6 +213,36 @@ TEST_F('NetInternalsTest', 'netInternalsEventsViewFilter', function() {
checkFilter('Quoted" source', [false, false]);
checkFilter('Quoted "String', [true, false]);
+ // Test toggling sort method, without any filters.
+ var eventsView = EventsView.getInstance();
+ eventsView.setFilterText_('');
+ $(EventsView.SORT_BY_DESCRIPTION_ID).click();
+ expectEquals('sort:desc', eventsView.getFilterText_());
+ $(EventsView.SORT_BY_DESCRIPTION_ID).click();
+ expectEquals('-sort:desc', eventsView.getFilterText_());
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('sort:id', eventsView.getFilterText_());
+
+ // Sort by default is by ID, so toggling ID when there's no filter results in
+ // sort:-id.
+ eventsView.setFilterText_('');
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('-sort:id', eventsView.getFilterText_());
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('sort:id', eventsView.getFilterText_());
+
+ // Test toggling sort method with filters.
+ eventsView.setFilterText_('text');
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('-sort:id text', eventsView.getFilterText_());
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('sort:id text', eventsView.getFilterText_());
+ $(EventsView.SORT_BY_SOURCE_TYPE_ID).click();
+ expectEquals('sort:source text', eventsView.getFilterText_());
+ eventsView.setFilterText_('text sort:id "more text"');
+ $(EventsView.SORT_BY_ID_ID).click();
+ expectEquals('-sort:id text "more text"', eventsView.getFilterText_());
+
testDone();
});
« no previous file with comments | « chrome/browser/resources/net_internals/source_filter_parser.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698