Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 485103005: Preparation for removing same origin check as blink checks for the same (Closed)

Created:
6 years, 4 months ago by pals
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This CL prepares chromium for removing same origin check as blink checks for the same. BUG=406236 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291375

Patch Set 1 #

Total comments: 1

Patch Set 2 : TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/renderer/render_view_impl.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pals
This is required to land https://codereview.chromium.org/392993005/. I shall create a follow up CL to remove ...
6 years, 4 months ago (2014-08-21 13:53:27 UTC) #1
jamesr
Is there a bug tracking this work and describing the test plan? If not, file ...
6 years, 4 months ago (2014-08-21 21:06:44 UTC) #2
pals
On 2014/08/21 21:06:44, jamesr wrote: > Is there a bug tracking this work and describing ...
6 years, 4 months ago (2014-08-22 05:29:50 UTC) #3
jamesr
Thanks, lgtm https://codereview.chromium.org/485103005/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/485103005/diff/1/content/renderer/render_view_impl.cc#newcode3957 content/renderer/render_view_impl.cc:3957: void RenderViewImpl::registerProtocolHandler(const WebString& scheme, annotate with a ...
6 years, 4 months ago (2014-08-22 05:34:37 UTC) #4
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 4 months ago (2014-08-22 05:45:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/485103005/40001
6 years, 4 months ago (2014-08-22 05:45:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 06:41:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 07:36:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1326)
6 years, 4 months ago (2014-08-22 07:36:16 UTC) #9
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 4 months ago (2014-08-22 07:57:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/485103005/40001
6 years, 4 months ago (2014-08-22 07:58:16 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 10:34:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (40001) as 291375

Powered by Google App Engine
This is Rietveld 408576698