Preparation for removing same origin check as blink checks for the same

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 3936 matching lines @@
   GURL base(base_url);
   GURL absolute_url = base.Resolve(base::UTF16ToUTF8(url.string()));
   if (base.GetOrigin() != absolute_url.GetOrigin())
     return;
   Send(new ViewHostMsg_UnregisterProtocolHandler(routing_id_,
                                                  base::UTF16ToUTF8(scheme),
                                                  absolute_url,
                                                  user_gesture));
 }
 
+void RenderViewImpl::registerProtocolHandler(const WebString& scheme,

[jamesr, 2014/08/22 05:34:36]

annotate with a comment or something that the registerProtocolHandler versions
that take a base_url are going away, otherwise this looks like needlessly
duplicate code.  a good way would be to add a comment like this:

// TODO(your user name): Remove once blink patch lands. http://crbug.com/21345

to the functions you plan to delete soon

+                                             const WebURL& url,
+                                             const WebString& title) {
+  bool user_gesture = WebUserGestureIndicator::isProcessingUserGesture();
+  Send(new ViewHostMsg_RegisterProtocolHandler(routing_id_,
+                                               base::UTF16ToUTF8(scheme),
+                                               url,
+                                               title,
+                                               user_gesture));
+}
+
+void RenderViewImpl::unregisterProtocolHandler(const WebString& scheme,
+                                               const WebURL& url) {
+  bool user_gesture = WebUserGestureIndicator::isProcessingUserGesture();
+  Send(new ViewHostMsg_UnregisterProtocolHandler(routing_id_,
+                                                 base::UTF16ToUTF8(scheme),
+                                                 url,
+                                                 user_gesture));
+}
+
 blink::WebPageVisibilityState RenderViewImpl::visibilityState() const {
   blink::WebPageVisibilityState current_state = is_hidden() ?
       blink::WebPageVisibilityStateHidden :
       blink::WebPageVisibilityStateVisible;
   blink::WebPageVisibilityState override_state = current_state;
   // TODO(jam): move this method to WebFrameClient.
   if (GetContentClient()->renderer()->
           ShouldOverridePageVisibilityState(main_render_frame_.get(),
                                             &override_state))
     return override_state;
@@ skipping 308 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content