Increase the 20 second timeout value of the unittest framework higher

Increase the 20 second timeout value of the unittest framework higher

Tests going over the 20 seconds is causing us random failures on the buildbots.
Until we have a custom unittest configuration for our testing scripts, we'll
increase the default timeout to 2 minutes.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29349

[ricow1, 2013-10-28 10:34:17]

LGTM

[kustermann, 2013-10-28 10:36:54]

Committed patchset #1 manually as r29349 (presubmit successful).

[kustermann, 2013-10-28 10:38:59]

@iposva/blois: I increased it now to two minutes -- so we shouldn't need any
"opting out tests".

This is not mid/long term solution.

We should still figure out why the tests are suddently taking more time to
execute -- maybe performance regressions ...?

[kasperl, 2013-10-28 11:17:33]

LGTM as a short-term fix.

[Ivan Posva, 2013-10-28 18:36:01]

On 2013/10/28 10:38:59, kustermann wrote:
> @iposva/blois: I increased it now to two minutes -- so we shouldn't need any
> "opting out tests".
> 
> This is not mid/long term solution.
> 
> We should still figure out why the tests are suddently taking more time to
> execute -- maybe performance regressions ...?

The problem with the unit test framework is that we do not report the times of
the individual test runs, so it is not clear whether these tests were at 19.8
seconds and now just by some little fluctuation we are over the threshold or
whether we at least doubled the runtime. We should probably print out a message
if a test finishes within 10% or 20% of the allowable timeout.

-Ivan

[Ivan Posva, 2013-10-28 18:37:47]

On 2013/10/28 18:36:01, Ivan Posva wrote:
> On 2013/10/28 10:38:59, kustermann wrote:
> > @iposva/blois: I increased it now to two minutes -- so we shouldn't need any
> > "opting out tests".
> > 
> > This is not mid/long term solution.
> > 
> > We should still figure out why the tests are suddently taking more time to
> > execute -- maybe performance regressions ...?
> 
> The problem with the unit test framework is that we do not report the times of
> the individual test runs, so it is not clear whether these tests were at 19.8
> seconds and now just by some little fluctuation we are over the threshold or
> whether we at least doubled the runtime. We should probably print out a
message
> if a test finishes within 10% or 20% of the allowable timeout.
> 
> -Ivan

Filed https://code.google.com/p/dart/issues/detail?id=14531

-Ivan