Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 484893004: Mojo: Make Core own a PlatformSupport, and plumb it through to Channel. (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Make Core own a PlatformSupport, and plumb it through to Channel. And make SharedBufferDispatcher::Deserialize() use the PlatformSupport from the Channel that's passed to it. (For now, just initialize Core's platform_dispatcher_ with a SimplePlatformSupport. Next, I'll have to add it to Core's ctor and do all the required plumbing for that.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290475

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -33 lines) Patch
M mojo/embedder/embedder.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M mojo/system/channel.h View 1 4 chunks +14 lines, -1 line 0 comments Download
M mojo/system/channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/system/channel_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M mojo/system/core.h View 6 chunks +17 lines, -5 lines 0 comments Download
M mojo/system/core.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 9 chunks +15 lines, -8 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-18 23:17:53 UTC) #1
darin (slow to review)
LGTM modulo comments below: https://codereview.chromium.org/484893004/diff/1/mojo/system/channel.h File mojo/system/channel.h (right): https://codereview.chromium.org/484893004/diff/1/mojo/system/channel.h#newcode63 mojo/system/channel.h:63: // |platform_support| (typically owned by ...
6 years, 4 months ago (2014-08-18 23:42:58 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/484893004/diff/1/mojo/system/channel.h File mojo/system/channel.h (right): https://codereview.chromium.org/484893004/diff/1/mojo/system/channel.h#newcode63 mojo/system/channel.h:63: // |platform_support| (typically owned by |Core|) must remain ...
6 years, 4 months ago (2014-08-19 00:02:32 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 4 months ago (2014-08-19 00:02:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/484893004/20001
6 years, 4 months ago (2014-08-19 00:05:48 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 03:34:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290475

Powered by Google App Engine
This is Rietveld 408576698