Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: mojo/system/remote_message_pipe_unittest.cc

Issue 484893004: Mojo: Make Core own a PlatformSupport, and plumb it through to Channel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/multiprocess_message_pipe_unittest.cc ('k') | mojo/system/shared_buffer_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/remote_message_pipe_unittest.cc
diff --git a/mojo/system/remote_message_pipe_unittest.cc b/mojo/system/remote_message_pipe_unittest.cc
index 0a961bfa73a3e76cfe730af734907dc145483a27..f63543623b4afbe8d0b5d9ee40b999be2d50b993 100644
--- a/mojo/system/remote_message_pipe_unittest.cc
+++ b/mojo/system/remote_message_pipe_unittest.cc
@@ -94,6 +94,7 @@ class RemoteMessagePipeTest : public testing::Test {
base::Unretained(this)));
}
+ embedder::PlatformSupport* platform_support() { return &platform_support_; }
test::TestIOThread* io_thread() { return &io_thread_; }
private:
@@ -123,7 +124,7 @@ class RemoteMessagePipeTest : public testing::Test {
CHECK(channel_index == 0 || channel_index == 1);
CHECK(!channels_[channel_index]);
- channels_[channel_index] = new Channel();
+ channels_[channel_index] = new Channel(&platform_support_);
CHECK(channels_[channel_index]->Init(
RawChannel::Create(platform_handles_[channel_index].Pass())));
}
@@ -171,6 +172,7 @@ class RemoteMessagePipeTest : public testing::Test {
SetUpOnIOThread();
}
+ embedder::SimplePlatformSupport platform_support_;
test::TestIOThread io_thread_;
embedder::ScopedPlatformHandle platform_handles_[2];
scoped_refptr<Channel> channels_[2];
@@ -702,11 +704,10 @@ TEST_F(RemoteMessagePipeTest, MAYBE_SharedBufferPassing) {
ConnectMessagePipes(mp0, mp1);
// We'll try to pass this dispatcher.
- embedder::SimplePlatformSupport platform_support;
scoped_refptr<SharedBufferDispatcher> dispatcher;
EXPECT_EQ(MOJO_RESULT_OK,
SharedBufferDispatcher::Create(
- &platform_support,
+ platform_support(),
SharedBufferDispatcher::kDefaultCreateOptions,
100,
&dispatcher));
« no previous file with comments | « mojo/system/multiprocess_message_pipe_unittest.cc ('k') | mojo/system/shared_buffer_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698