Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions

ui/gfx/font_render_params_win.cc

Index: ui/gfx/font_render_params_win.cc
diff --git a/ui/gfx/font_render_params_win.cc b/ui/gfx/font_render_params_win.cc
index 2ad1b5bf42c94d622fa4f845ca4218472643c428..a6fc6186cdd2bad20e35654c2acf7a8396828faa 100644
--- a/ui/gfx/font_render_params_win.cc
+++ b/ui/gfx/font_render_params_win.cc
@@ -19,7 +19,7 @@ class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
     return Singleton<CachedFontRenderParams>::get();
   }
 
-  const FontRenderParams& GetParams() {
+  const FontRenderParams& GetParams(bool for_web_contents) {
     if (params_)
       return *params_;
 
@@ -34,7 +34,8 @@ class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
     BOOL enabled = false;
     if (SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, &enabled, 0) && enabled) {
       params_->antialiasing = true;
-      params_->subpixel_positioning = true;
+      // Subpixel positioning is not yet implemented for UI. crbug.com/389649
+      params_->subpixel_positioning = for_web_contents;

[Daniel Erat, 2014/08/25 18:27:12]

(this is fine, but note that blink doesn't look at this now afaik and i'll be
deleting it from FontRenderParams (hopefully) soon)

[ckocagil, 2014/08/25 20:49:12]

Okay, I'm not touching it in this CL then.

 
       UINT type = 0;
       if (SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, &type, 0) &&
@@ -77,7 +78,8 @@ FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
   // Customized font rendering settings are not supported, only defaults.
   if (!query.is_empty() || family_out)
     NOTIMPLEMENTED();
-  return CachedFontRenderParams::GetInstance()->GetParams();
+  return CachedFontRenderParams::GetInstance()->GetParams(
+      query.for_web_contents);
 }
 
 }  // namespace gfx