Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions

ui/gfx/font_render_params_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font_render_params.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "ui/gfx/win/singleton_hwnd.h"
 
 namespace gfx {
 
 namespace {
 
 // Caches font render params and updates them on system notifications.
 class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
  public:
   static CachedFontRenderParams* GetInstance() {
     return Singleton<CachedFontRenderParams>::get();
   }
 
-  const FontRenderParams& GetParams() {
+  const FontRenderParams& GetParams(bool for_web_contents) {
     if (params_)
       return *params_;
 
     params_.reset(new FontRenderParams());
     params_->antialiasing = false;
     params_->subpixel_positioning = false;
     params_->autohinter = false;
     params_->use_bitmaps = false;
     params_->hinting = FontRenderParams::HINTING_MEDIUM;
     params_->subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
 
     BOOL enabled = false;
     if (SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, &enabled, 0) && enabled) {
       params_->antialiasing = true;
-      params_->subpixel_positioning = true;
+      // Subpixel positioning is not yet implemented for UI. crbug.com/389649
+      params_->subpixel_positioning = for_web_contents;

[Daniel Erat, 2014/08/25 18:27:12]

(this is fine, but note that blink doesn't look at this now afaik and i'll be
deleting it from FontRenderParams (hopefully) soon)

[ckocagil, 2014/08/25 20:49:12]

Okay, I'm not touching it in this CL then.

 
       UINT type = 0;
       if (SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, &type, 0) &&
           type == FE_FONTSMOOTHINGCLEARTYPE) {
         params_->subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_RGB;
       }
     }
     gfx::SingletonHwnd::GetInstance()->AddObserver(this);
     return *params_;
   }
@@ skipping 22 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(CachedFontRenderParams);
 };
 
 }  // namespace
 
 FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
                                      std::string* family_out) {
   // Customized font rendering settings are not supported, only defaults.
   if (!query.is_empty() || family_out)
     NOTIMPLEMENTED();
-  return CachedFontRenderParams::GetInstance()->GetParams();
+  return CachedFontRenderParams::GetInstance()->GetParams(
+      query.for_web_contents);
 }
 
 }  // namespace gfx