Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 484783002: Pepper: Report NaCl exit status over Chromium IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes for mseaborn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc
diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
index d570f4cfc5b25f158c6682b9a59ecce4d77a3af4..ffce56320dedd85df0dc9ae4d7f82fa6291d2142 100644
--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc
+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
@@ -238,7 +238,8 @@ void PluginReverseInterface::ReportCrash() {
}
void PluginReverseInterface::ReportExitStatus(int exit_status) {
dmichael (off chromium) 2014/08/22 16:41:07 So can we get rid of this function?
teravest 2014/08/22 16:51:58 Not yet. nacl::ReverseInterface::ReportExitStatus
- service_runtime_->set_exit_status(exit_status);
+ // We do nothing here; reporting exit status is handled through a separate
+ // embedder interface.
}
int64_t PluginReverseInterface::RequestQuotaForWrite(
@@ -582,10 +583,4 @@ ServiceRuntime::~ServiceRuntime() {
NaClMutexDtor(&mu_);
}
-void ServiceRuntime::set_exit_status(int exit_status) {
- nacl::MutexLocker take(&mu_);
- if (main_service_runtime_)
- plugin_->set_exit_status(exit_status & 0xff);
-}
-
} // namespace plugin

Powered by Google App Engine
This is Rietveld 408576698