Pepper: Report NaCl exit status over Chromium IPC.

ppapi/native_client/src/trusted/plugin/service_runtime.cc

 /*
  * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime"
 
 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h"
 
@@ skipping 219 matching lines @@
     pp::Module::Get()->core()->CallOnMainThread(0, crash_cb_, PP_OK);
     // Clear the callback to avoid it gets invoked twice.
     crash_cb_ = pp::CompletionCallback();
   } else {
     NaClLog(1,
             "PluginReverseInterface::ReportCrash:"
             " crash_cb_ not valid, skipping\n");
   }
 }
 
 void PluginReverseInterface::ReportExitStatus(int exit_status) {

[dmichael (off chromium), 2014/08/22 16:41:07]

So can we get rid of this function?

[teravest, 2014/08/22 16:51:58]

Not yet.
nacl::ReverseInterface::ReportExitStatus is pure virtual.

After this change, there could be another NaCl change to remove the function
there, and then this one could be removed.

-  service_runtime_->set_exit_status(exit_status);
+  // We do nothing here; reporting exit status is handled through a separate
+  // embedder interface.
 }
 
 int64_t PluginReverseInterface::RequestQuotaForWrite(
     nacl::string file_id, int64_t offset, int64_t bytes_to_write) {
   return bytes_to_write;
 }
 
 ServiceRuntime::ServiceRuntime(Plugin* plugin,
                                PP_Instance pp_instance,
                                bool main_service_runtime,
@@ skipping 323 matching lines @@
   if (reverse_service_ != NULL)
     reverse_service_->Unref();
 
   rev_interface_->Unref();
 
   anchor_->Unref();
   NaClCondVarDtor(&cond_);
   NaClMutexDtor(&mu_);
 }
 
-void ServiceRuntime::set_exit_status(int exit_status) {
-  nacl::MutexLocker take(&mu_);
-  if (main_service_runtime_)
-    plugin_->set_exit_status(exit_status & 0xff);
-}
-
 }  // namespace plugin