Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 484653002: Finish TODO in Schedule. s/entry/start/g and s/exit/end/g to be more regular. (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Finish TODO in Schedule. s/entry/start/g and s/exit/end/g to be more regular. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -85 lines) Patch
M src/compiler/raw-machine-assembler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/schedule.h View 4 chunks +5 lines, -11 lines 0 comments Download
M src/compiler/scheduler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/structured-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-instruction.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 22 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-18 13:24:38 UTC) #1
Jarin
lgtm
6 years, 4 months ago (2014-08-18 13:26:37 UTC) #2
titzer
6 years, 4 months ago (2014-08-18 13:28:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23161 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698