Finish TODO in Schedule. s/entry/start/g and s/exit/end/g to be more regular.

test/cctest/compiler/test-instruction.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler/code-generator.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
@@ skipping 41 matching lines @@
     if (schedule.rpo_order()->size() == 0) {
       // Compute the RPO order.
       Scheduler::ComputeSpecialRPO(&schedule);
       DCHECK(schedule.rpo_order()->size() > 0);
     }
     code = new TestInstrSeq(&linkage, &graph, &schedule);
   }
 
   Node* Int32Constant(int32_t val) {
     Node* node = graph.NewNode(common.Int32Constant(val));
-    schedule.AddNode(schedule.entry(), node);
+    schedule.AddNode(schedule.start(), node);
     return node;
   }
 
   Node* Float64Constant(double val) {
     Node* node = graph.NewNode(common.Float64Constant(val));
-    schedule.AddNode(schedule.entry(), node);
+    schedule.AddNode(schedule.start(), node);
     return node;
   }
 
   Node* Parameter(int32_t which) {
     Node* node = graph.NewNode(common.Parameter(which));
-    schedule.AddNode(schedule.entry(), node);
+    schedule.AddNode(schedule.start(), node);
     return node;
   }
 
   Node* NewNode(BasicBlock* block) {
     Node* node = graph.NewNode(common.Int32Constant(111));
     schedule.AddNode(block, node);
     return node;
   }
 
   int NewInstr(BasicBlock* block) {
@@ skipping 11 matching lines @@
 };
 
 
 TEST(InstructionBasic) {
   InstructionTester R;
 
   for (int i = 0; i < 10; i++) {
     R.Int32Constant(i);  // Add some nodes to the graph.
   }
 
-  BasicBlock* last = R.schedule.entry();
+  BasicBlock* last = R.schedule.start();
   for (int i = 0; i < 5; i++) {
     BasicBlock* block = R.schedule.NewBasicBlock();
     R.schedule.AddGoto(last, block);
     last = block;
   }
 
   R.allocCode();
 
   CHECK_EQ(R.graph.NodeCount(), R.code->ValueCount());
 
   BasicBlockVector* blocks = R.schedule.rpo_order();
   CHECK_EQ(static_cast<int>(blocks->size()), R.code->BasicBlockCount());
 
   int index = 0;
   for (BasicBlockVectorIter i = blocks->begin(); i != blocks->end();
        i++, index++) {
     BasicBlock* block = *i;
     CHECK_EQ(block, R.code->BlockAt(index));
     CHECK_EQ(-1, R.code->GetLoopEnd(block));
   }
 }
 
 
 TEST(InstructionGetBasicBlock) {
   InstructionTester R;
 
-  BasicBlock* b0 = R.schedule.entry();
+  BasicBlock* b0 = R.schedule.start();
   BasicBlock* b1 = R.schedule.NewBasicBlock();
   BasicBlock* b2 = R.schedule.NewBasicBlock();
-  BasicBlock* b3 = R.schedule.exit();
+  BasicBlock* b3 = R.schedule.end();
 
   R.schedule.AddGoto(b0, b1);
   R.schedule.AddGoto(b1, b2);
   R.schedule.AddGoto(b2, b3);
 
   R.allocCode();
 
   R.code->StartBlock(b0);
   int i0 = R.NewInstr(b0);
   int i1 = R.NewInstr(b0);
@@ skipping 34 matching lines @@
   CHECK_EQ(b2, R.code->GetBasicBlock(b2->last_instruction_index()));
 
   CHECK_EQ(b3, R.code->GetBasicBlock(b3->first_instruction_index()));
   CHECK_EQ(b3, R.code->GetBasicBlock(b3->last_instruction_index()));
 }
 
 
 TEST(InstructionIsGapAt) {
   InstructionTester R;
 
-  BasicBlock* b0 = R.schedule.entry();
+  BasicBlock* b0 = R.schedule.start();
   R.schedule.AddReturn(b0, R.Int32Constant(1));
 
   R.allocCode();
   TestInstr* i0 = TestInstr::New(R.zone(), 100);
   TestInstr* g = TestInstr::New(R.zone(), 103)->MarkAsControl();
   R.code->StartBlock(b0);
   R.code->AddInstruction(i0, b0);
   R.code->AddInstruction(g, b0);
   R.code->EndBlock(b0);
 
   CHECK_EQ(true, R.code->InstructionAt(0)->IsBlockStart());
 
   CHECK_EQ(true, R.code->IsGapAt(0));   // Label
   CHECK_EQ(true, R.code->IsGapAt(1));   // Gap
   CHECK_EQ(false, R.code->IsGapAt(2));  // i0
   CHECK_EQ(true, R.code->IsGapAt(3));   // Gap
   CHECK_EQ(true, R.code->IsGapAt(4));   // Gap
   CHECK_EQ(false, R.code->IsGapAt(5));  // g
 }
 
 
 TEST(InstructionIsGapAt2) {
   InstructionTester R;
 
-  BasicBlock* b0 = R.schedule.entry();
-  BasicBlock* b1 = R.schedule.exit();
+  BasicBlock* b0 = R.schedule.start();
+  BasicBlock* b1 = R.schedule.end();
   R.schedule.AddGoto(b0, b1);
   R.schedule.AddReturn(b1, R.Int32Constant(1));
 
   R.allocCode();
   TestInstr* i0 = TestInstr::New(R.zone(), 100);
   TestInstr* g = TestInstr::New(R.zone(), 103)->MarkAsControl();
   R.code->StartBlock(b0);
   R.code->AddInstruction(i0, b0);
   R.code->AddInstruction(g, b0);
   R.code->EndBlock(b0);
@@ skipping 21 matching lines @@
   CHECK_EQ(false, R.code->IsGapAt(8));   // i1
   CHECK_EQ(true, R.code->IsGapAt(9));    // Gap
   CHECK_EQ(true, R.code->IsGapAt(10));   // Gap
   CHECK_EQ(false, R.code->IsGapAt(11));  // g1
 }
 
 
 TEST(InstructionAddGapMove) {
   InstructionTester R;
 
-  BasicBlock* b0 = R.schedule.entry();
+  BasicBlock* b0 = R.schedule.start();
   R.schedule.AddReturn(b0, R.Int32Constant(1));
 
   R.allocCode();
   TestInstr* i0 = TestInstr::New(R.zone(), 100);
   TestInstr* g = TestInstr::New(R.zone(), 103)->MarkAsControl();
   R.code->StartBlock(b0);
   R.code->AddInstruction(i0, b0);
   R.code->AddInstruction(g, b0);
   R.code->EndBlock(b0);
 
@@ skipping 71 matching lines @@
           CHECK_EQ(inputs[z], m->InputAt(z));
         }
 
         for (size_t z = 0; z < k; z++) {
           CHECK_EQ(temps[z], m->TempAt(z));
         }
       }
     }
   }
 }