Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4319)

Unified Diff: chrome/renderer/spellchecker/hunspell_engine.cc

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/spellchecker/hunspell_engine.cc
diff --git a/chrome/renderer/spellchecker/hunspell_engine.cc b/chrome/renderer/spellchecker/hunspell_engine.cc
index f8071efc69d4823d4c67a3a15086af8662771c10..9800e283273ea09e2aef3135f64210f28fd8b2cb 100644
--- a/chrome/renderer/spellchecker/hunspell_engine.cc
+++ b/chrome/renderer/spellchecker/hunspell_engine.cc
@@ -15,7 +15,6 @@
#include "content/public/renderer/render_thread.h"
#include "third_party/hunspell/src/hunspell/hunspell.hxx"
-using base::TimeTicks;
using content::RenderThread;
namespace {
@@ -63,12 +62,15 @@ void HunspellEngine::InitializeHunspell() {
bdict_file_.reset(new base::MemoryMappedFile);
if (bdict_file_->Initialize(file_.Pass())) {
- TimeTicks debug_start_time = base::Histogram::DebugNow();
+#ifndef NDEBUG
+ base::TimeTicks debug_start_time = base::TimeTicks::Now();
+#endif
hunspell_.reset(new Hunspell(bdict_file_->data(), bdict_file_->length()));
-
- DHISTOGRAM_TIMES("Spellcheck.InitTime",
- base::Histogram::DebugNow() - debug_start_time);
+#ifndef NDEBUG
+ LOCAL_HISTOGRAM_TIMES("Spellcheck.InitTime",
+ base::TimeTicks::Now() - debug_start_time);
+#endif
groby-ooo-7-16 2014/08/25 21:12:11 Feel free to remove this histogram.
Alexei Svitkine (slow) 2014/08/25 21:21:03 Done.
} else {
NOTREACHED() << "Could not mmap spellchecker dictionary.";
}

Powered by Google App Engine
This is Rietveld 408576698