Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/spellchecker/spellcheck_platform_mac.mm

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_platform_mac.mm
diff --git a/chrome/browser/spellchecker/spellcheck_platform_mac.mm b/chrome/browser/spellchecker/spellcheck_platform_mac.mm
index a5951ed5169ec6b6315b76346147259bd0b7bb4e..5eee7b058a79d4dab0b545de6f66f0121cfd3b4b 100644
--- a/chrome/browser/spellchecker/spellcheck_platform_mac.mm
+++ b/chrome/browser/spellchecker/spellcheck_platform_mac.mm
@@ -197,11 +197,15 @@ bool CheckSpelling(const base::string16& word_to_check, int tag) {
void FillSuggestionList(const base::string16& wrong_word,
std::vector<base::string16>* optional_suggestions) {
NSString* NS_wrong_word = base::SysUTF16ToNSString(wrong_word);
- TimeTicks debug_begin_time = base::Histogram::DebugNow();
+#ifndef NDEBUG
+ TimeTicks debug_begin_time = base::TimeTicks::Now();
+#endif
// The suggested words for |wrong_word|.
NSArray* guesses = [SharedSpellChecker() guessesForWord:NS_wrong_word];
- DHISTOGRAM_TIMES("Spellcheck.SuggestTime",
- base::Histogram::DebugNow() - debug_begin_time);
+#ifndef NDEBUG
+ LOCAL_HISTOGRAM_TIMES("Spellcheck.SuggestTime",
groby-ooo-7-16 2014/08/25 21:12:11 Feel free to remove
Alexei Svitkine (slow) 2014/08/25 21:21:03 Done.
+ base::TimeTicks::Now() - debug_begin_time);
+#endif
for (int i = 0; i < static_cast<int>([guesses count]); ++i) {
if (i < chrome::spellcheck_common::kMaxSuggestions) {

Powered by Google App Engine
This is Rietveld 408576698