Add LOCAL_ prefix to non-UMA histogram macros.

Add LOCAL_ prefix to non-UMA histogram macros.

This makes it harder to accidently use the wrong
macro.

Also, removes the D* variants of the macros and
associated DebugNow() function. These were rarely
used and removing them removes clutter from the
header file. Existing uses converted to be behind
NDEBUG ifdefs.

No functional changes except for a fix to the
code in content_based_thumbnailing_algorithm.cc
which was incorrectly using a ternary operator for
the histogram name (which doesn't work since the
macros cache the histogram object) and removal
of local histograms Spellcheck.SuggestTime and
Spellcheck.InitTime per groby@.

Since this is an API rename, TBR'ing downstream
owners.

BUG=311349
TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium.org,agl@chromium.org,jam@chromium.org

Committed: https://crrev.com/c0fb802166c8389285c8a850bd47d2d96935f6f1
Cr-Commit-Position: refs/heads/master@{#291840}

[groby-ooo-7-16, 2014-08-25 21:12:12]

Drive-by for spellcheck.

https://codereview.chromium.org/484603006/diff/1/chrome/browser/spellchecker/...
File chrome/browser/spellchecker/spellcheck_platform_mac.mm (right):

https://codereview.chromium.org/484603006/diff/1/chrome/browser/spellchecker/...
chrome/browser/spellchecker/spellcheck_platform_mac.mm:206:
LOCAL_HISTOGRAM_TIMES("Spellcheck.SuggestTime",
Feel free to remove

https://codereview.chromium.org/484603006/diff/1/chrome/renderer/spellchecker...
File chrome/renderer/spellchecker/hunspell_engine.cc (right):

https://codereview.chromium.org/484603006/diff/1/chrome/renderer/spellchecker...
chrome/renderer/spellchecker/hunspell_engine.cc:73: #endif
Feel free to remove this histogram.

[Alexei Svitkine (slow), 2014-08-25 21:21:03]

https://codereview.chromium.org/484603006/diff/1/chrome/browser/spellchecker/...
File chrome/browser/spellchecker/spellcheck_platform_mac.mm (right):

https://codereview.chromium.org/484603006/diff/1/chrome/browser/spellchecker/...
chrome/browser/spellchecker/spellcheck_platform_mac.mm:206:
LOCAL_HISTOGRAM_TIMES("Spellcheck.SuggestTime",
On 2014/08/25 21:12:11, groby wrote:
> Feel free to remove

Done.

https://codereview.chromium.org/484603006/diff/1/chrome/renderer/spellchecker...
File chrome/renderer/spellchecker/hunspell_engine.cc (right):

https://codereview.chromium.org/484603006/diff/1/chrome/renderer/spellchecker...
chrome/renderer/spellchecker/hunspell_engine.cc:73: #endif
On 2014/08/25 21:12:11, groby wrote:
> Feel free to remove this histogram.

Done.

[Ilya Sherman, 2014-08-26 00:23:28]

Thanks for doing this cleanup, Alexei!  A lot of these look to me like they
might be intended to be UMA histograms rather than local ones; we'll see what
file owners say.

LGTM :)

https://codereview.chromium.org/484603006/diff/20001/base/metrics/sparse_hist...
File base/metrics/sparse_histogram.h (right):

https://codereview.chromium.org/484603006/diff/20001/base/metrics/sparse_hist...
base/metrics/sparse_histogram.h:23: #define HISTOGRAM_SPARSE_COMMON(name,
sample, flag) \
Optional nit: Should we perhaps add a "PRIVATE_" prefix to this macro?  One the
one hand, I don't think there's much likelihood of accidental use.  On the other
hand, it does seem like the sort of thing that would be made more hidden if it
weren't a macro.

https://codereview.chromium.org/484603006/diff/20001/base/metrics/sparse_hist...
base/metrics/sparse_histogram.h:32: HISTOGRAM_SPARSE_COMMON(name, sample,
base::HistogramBase::kNoFlags)
Actually, are there any uses of local sparse histograms?  Maybe we should try
making sparse histograms be UMA-only in flavor, and see if anyone complains?

https://codereview.chromium.org/484603006/diff/20001/content/browser/plugin_l...
File content/browser/plugin_loader_posix.cc (right):

https://codereview.chromium.org/484603006/diff/20001/content/browser/plugin_l...
content/browser/plugin_loader_posix.cc:214: *
base::Time::kMicrosecondsPerMillisecond);
nit: Looks like this line should be indented four more spaces?

[Alexei Svitkine (slow), 2014-08-26 00:54:01]

Done.

Will TBR= owners, but advise them to convert their histograms to UMA_ versions
in follow-up CLs if that was the original intention.

https://codereview.chromium.org/484603006/diff/20001/base/metrics/sparse_hist...
File base/metrics/sparse_histogram.h (right):

https://codereview.chromium.org/484603006/diff/20001/base/metrics/sparse_hist...
base/metrics/sparse_histogram.h:32: HISTOGRAM_SPARSE_COMMON(name, sample,
base::HistogramBase::kNoFlags)
On 2014/08/26 00:23:28, Ilya Sherman wrote:
> Actually, are there any uses of local sparse histograms?  Maybe we should try
> making sparse histograms be UMA-only in flavor, and see if anyone complains?

SGTM. Done.

Also, did a little bit of cleanup to the expanded block (e.g. removed the name
dcheck since it's not necessary because the object is never cached.)

https://codereview.chromium.org/484603006/diff/20001/content/browser/plugin_l...
File content/browser/plugin_loader_posix.cc (right):

https://codereview.chromium.org/484603006/diff/20001/content/browser/plugin_l...
content/browser/plugin_loader_posix.cc:214: *
base::Time::kMicrosecondsPerMillisecond);
On 2014/08/26 00:23:28, Ilya Sherman wrote:
> nit: Looks like this line should be indented four more spaces?

Done. Also put the "*" up on the line above for consistency with the other
histogram in this file (as well as indenting that one too).

[Alexei Svitkine (slow), 2014-08-26 01:02:05]

asvitkine@chromium.org changed reviewers:
+ agl@chromium.org, groby@chromium.org, jam@chromium.org, jeremy@chromium.org,
reveman@chromium.org, zea@chromium.org

[Alexei Svitkine (slow), 2014-08-26 01:02:05]

Adding file owners TBR'd since this is an API rename with no functional changes.

TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium....

If any of the histograms here were not meant to be local, but instead were meant
to be sent up to UMA - please review: a) whether they should be marked UMA_ or
b) whether they should be removed entirely, since no noticed they weren't being
reported. Please do that in follow-up CLs, if necessary. Thanks!

[Alexei Svitkine (slow), 2014-08-26 01:02:59]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-08-26 01:09:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/484603006/40001

[commit-bot: I haz the power, 2014-08-26 02:18:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[commit-bot: I haz the power, 2014-08-26 04:40:21]

Committed patchset #3 (40001) as 5cb8835bc1e0d855ee8523cf6f86c49b9bcac0d0

[jeremy, 2014-08-26 08:26:48]

LGTM, thanks for making this change! Makes things much less error prone!

[commit-bot: I haz the power, 2014-09-10 02:40:30]

Patchset 3 (id:??) landed as
https://crrev.com/c0fb802166c8389285c8a850bd47d2d96935f6f1
Cr-Commit-Position: refs/heads/master@{#291840}