Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: content/child/web_database_observer_impl.cc

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/child_histogram_message_filter.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_database_observer_impl.cc
diff --git a/content/child/web_database_observer_impl.cc b/content/child/web_database_observer_impl.cc
index 62eee5f0094932d38121f083864ef33f60037e0e..686b51f5bc0b9b2ba8481cc9f01a86b6fc78f639 100644
--- a/content/child/web_database_observer_impl.cc
+++ b/content/child/web_database_observer_impl.cc
@@ -38,8 +38,8 @@ int DetermineHistogramResult(int websql_error, int sqlite_error) {
return std::min(websql_error + 30, kResultHistogramSize - 1);
}
-#define HISTOGRAM_WEBSQL_RESULT(name, is_sync_database, \
- callsite, websql_error, sqlite_error) \
+#define UMA_HISTOGRAM_WEBSQL_RESULT(name, is_sync_database, \
+ callsite, websql_error, sqlite_error) \
do { \
DCHECK(callsite < kCallsiteHistogramSize); \
int result = DetermineHistogramResult(websql_error, sqlite_error); \
@@ -104,8 +104,8 @@ void WebDatabaseObserverImpl::reportOpenDatabaseResult(
const WebString& database_name,
bool is_sync_database,
int callsite, int websql_error, int sqlite_error) {
- HISTOGRAM_WEBSQL_RESULT("OpenResult", is_sync_database,
- callsite, websql_error, sqlite_error);
+ UMA_HISTOGRAM_WEBSQL_RESULT("OpenResult", is_sync_database, callsite,
+ websql_error, sqlite_error);
HandleSqliteError(origin_identifier, database_name, sqlite_error);
}
@@ -114,8 +114,8 @@ void WebDatabaseObserverImpl::reportChangeVersionResult(
const WebString& database_name,
bool is_sync_database,
int callsite, int websql_error, int sqlite_error) {
- HISTOGRAM_WEBSQL_RESULT("ChangeVersionResult", is_sync_database,
- callsite, websql_error, sqlite_error);
+ UMA_HISTOGRAM_WEBSQL_RESULT("ChangeVersionResult", is_sync_database, callsite,
+ websql_error, sqlite_error);
HandleSqliteError(origin_identifier, database_name, sqlite_error);
}
@@ -124,8 +124,8 @@ void WebDatabaseObserverImpl::reportStartTransactionResult(
const WebString& database_name,
bool is_sync_database,
int callsite, int websql_error, int sqlite_error) {
- HISTOGRAM_WEBSQL_RESULT("BeginResult", is_sync_database,
- callsite, websql_error, sqlite_error);
+ UMA_HISTOGRAM_WEBSQL_RESULT("BeginResult", is_sync_database, callsite,
+ websql_error, sqlite_error);
HandleSqliteError(origin_identifier, database_name, sqlite_error);
}
@@ -134,8 +134,8 @@ void WebDatabaseObserverImpl::reportCommitTransactionResult(
const WebString& database_name,
bool is_sync_database,
int callsite, int websql_error, int sqlite_error) {
- HISTOGRAM_WEBSQL_RESULT("CommitResult", is_sync_database,
- callsite, websql_error, sqlite_error);
+ UMA_HISTOGRAM_WEBSQL_RESULT("CommitResult", is_sync_database, callsite,
+ websql_error, sqlite_error);
HandleSqliteError(origin_identifier, database_name, sqlite_error);
}
@@ -144,8 +144,8 @@ void WebDatabaseObserverImpl::reportExecuteStatementResult(
const WebString& database_name,
bool is_sync_database,
int callsite, int websql_error, int sqlite_error) {
- HISTOGRAM_WEBSQL_RESULT("StatementResult", is_sync_database,
- callsite, websql_error, sqlite_error);
+ UMA_HISTOGRAM_WEBSQL_RESULT("StatementResult", is_sync_database, callsite,
+ websql_error, sqlite_error);
HandleSqliteError(origin_identifier, database_name, sqlite_error);
}
« no previous file with comments | « content/child/child_histogram_message_filter.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698