Issue 48393003: Add InputMethodObserver support into InputMethodBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48393003: Add InputMethodObserver support into InputMethodBase (Closed)

Created:
7 years, 1 month ago by yukawa

Modified:
7 years, 1 month ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add InputMethodObserver support into InputMethodBase This is a preparation CL to fix issue 164964. Following observer callbacks are defined but not yet supported by ui::InputMethodBase and its sub classes. - InputMethodObserver::OnCaretBoundsChanged - InputMethodObserver::OnInputLocaleChanged This CL makes these callbacks functional for each sub class of ui::InputMethodBase. BUG=164964 TEST=ui_unittests --gtest_filter=InputMethodBaseTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231563

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -111 lines)			Patch
M	ui/base/ime/input_method_base.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/ime/input_method_base.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	ui/base/ime/input_method_base_unittest.cc	View	1 2	5 chunks	+138 lines, -25 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View	1	3 chunks	+61 lines, -59 lines	0 comments	Download
M	ui/base/ime/input_method_imm32.cc	View		1 chunk	+16 lines, -19 lines	0 comments	Download
M	ui/base/ime/input_method_linux_x11.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	ui/base/ime/input_method_tsf.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ime/input_method_win.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/48393003/300001

7 years, 1 month ago (2013-10-29 02:46:27 UTC) #3

Message was sent while issue was closed.

Change committed as 231563

Expand Messages | Collapse Messages

Issue 48393003: Add InputMethodObserver support into InputMethodBase (Closed)

Description

Patch Set 1 : #

Patch Set 2 : add unit test #

Patch Set 3 : Fix -Werror=sign-compare #

Messages