Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: ui/base/ime/input_method_linux_x11.cc

Issue 48393003: Add InputMethodObserver support into InputMethodBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix -Werror=sign-compare Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_imm32.cc ('k') | ui/base/ime/input_method_tsf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_linux_x11.cc
diff --git a/ui/base/ime/input_method_linux_x11.cc b/ui/base/ime/input_method_linux_x11.cc
index 415a7bde2a7aadb9f898e3a659b1e49a3c646787..59737616c29df806fe00ecfcaa7f520247c7af5c 100644
--- a/ui/base/ime/input_method_linux_x11.cc
+++ b/ui/base/ime/input_method_linux_x11.cc
@@ -110,13 +110,12 @@ void InputMethodLinuxX11::OnTextInputTypeChanged(
InputMethodBase::OnTextInputTypeChanged(client);
}
-void InputMethodLinuxX11::OnCaretBoundsChanged(
- const TextInputClient* client) {
- if (!IsTextInputClientFocused(client))
- return;
-
- input_method_context_->OnCaretBoundsChanged(
- GetTextInputClient()->GetCaretBounds());
+void InputMethodLinuxX11::OnCaretBoundsChanged(const TextInputClient* client) {
+ if (IsTextInputClientFocused(client)) {
+ input_method_context_->OnCaretBoundsChanged(
+ GetTextInputClient()->GetCaretBounds());
+ }
+ InputMethodBase::OnCaretBoundsChanged(client);
}
void InputMethodLinuxX11::CancelComposition(const TextInputClient* client) {
@@ -128,6 +127,7 @@ void InputMethodLinuxX11::CancelComposition(const TextInputClient* client) {
}
void InputMethodLinuxX11::OnInputLocaleChanged() {
+ InputMethodBase::OnInputLocaleChanged();
}
std::string InputMethodLinuxX11::GetInputLocale() {
« no previous file with comments | « ui/base/ime/input_method_imm32.cc ('k') | ui/base/ime/input_method_tsf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698